Skip to content

✨ [#518] Add searchable objectTypes selector and sort alphabetically#769

Merged
OlhaZahoruiko merged 1 commit into
masterfrom
feature/518-searchable-object-types
Jun 15, 2026
Merged

✨ [#518] Add searchable objectTypes selector and sort alphabetically#769
OlhaZahoruiko merged 1 commit into
masterfrom
feature/518-searchable-object-types

Conversation

@OlhaZahoruiko

@OlhaZahoruiko OlhaZahoruiko commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #518

Changes

[Describe the changes here]

Checklist

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how
  • Architectural design record

    • If a design decision was made that changes functionality, create an architectural design record for it here

@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.72%. Comparing base (7e01a25) to head (562fb9e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #769   +/-   ##
=======================================
  Coverage   86.72%   86.72%           
=======================================
  Files         145      145           
  Lines        3149     3149           
  Branches      251      251           
=======================================
  Hits         2731     2731           
  Misses        370      370           
  Partials       48       48           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchfeature/518-searchable-object-types
Testbedubuntu-24.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
124.20 ms
(-4.84%)Baseline: 130.51 ms
137.04 ms
(90.63%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
20.37 ms
(-6.26%)Baseline: 21.73 ms
22.82 ms
(89.28%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
353.98 ms
(+0.77%)Baseline: 351.29 ms
368.85 ms
(95.97%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
353.50 ms
(+3.09%)Baseline: 342.91 ms
360.05 ms
(98.18%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
128.76 ms
(-0.51%)Baseline: 129.42 ms
135.89 ms
(94.75%)
🐰 View full continuous benchmarking report in Bencher

@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/518-searchable-object-types branch from fca49c6 to c259a97 Compare June 4, 2026 12:48
@OlhaZahoruiko OlhaZahoruiko marked this pull request as ready for review June 4, 2026 12:58
Comment thread src/objects/token/tests/test_admin.py Outdated
Comment thread src/objects/js/components/forms/searchable-select-input.js
Comment thread src/objects/js/components/admin/permissions/permission-form.js
@OlhaZahoruiko OlhaZahoruiko requested a review from stevenbal June 5, 2026 13:24
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/518-searchable-object-types branch from 9f54588 to 5d7f616 Compare June 8, 2026 08:39
@stevenbal stevenbal mentioned this pull request Jun 8, 2026
18 tasks
@stevenbal stevenbal force-pushed the feature/518-searchable-object-types branch from 5d7f616 to e862b2d Compare June 11, 2026 14:42
@stevenbal stevenbal force-pushed the feature/518-searchable-object-types branch from e862b2d to 562fb9e Compare June 11, 2026 14:46
@OlhaZahoruiko OlhaZahoruiko merged commit 185fb94 into master Jun 15, 2026
30 checks passed
@OlhaZahoruiko OlhaZahoruiko deleted the feature/518-searchable-object-types branch June 15, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I want to be able to search for objectTypes in permission view dropdown

3 participants