Fix window_range, and related bugs affecting :man when combined with number-lines
#5397
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, it was simply reporting a width of 0 at all times!
This fixes an issue where man.kak would fail to update in some situations. Specifically, if writing the man page to the buffer increased the max line number enough to cause the gutter to grow, this would change the available width, without triggering the resize hook that re-layouts the manpage.
I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
window_rangesimply did not work correctly; it always reported0for the width for some reasonwindow_rangewould not update plugins that needed to redraw (eg. man.kak), because those plugins useWinResize.I've added code to trigger that hook when the window_range width/height changes - I briefly considered adding a new hook for it, but I think most things that want to know when the window resizes will also care about window_range resizes, and doing it this way means some plugins get bugfixes for free! (such as man.kak)