autowrap: automatically set autowrap column highlighter #5191
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Maybe this is a good idea to change the default value to 0? |
stacyharper
force-pushed
the
better-autowrap-column
branch
3 times, most recently
from
fee5d2a to
8bc8949
Compare
stacyharper
changed the title
Contributor
Author
|
I rebased this one, to not depend on the other editorconfig git history. |
stacyharper
force-pushed
the
better-autowrap-column
branch
from
8bc8949 to
7160dd2
Compare
Owner
|
I wonder about this change, I am not sure most users would want enabling autowrap to automatically add a column highlighter, I wonder if those hooks should be wrapped into a command a user could explicitely call to opt-into this behaviour. |
Contributor
Author
|
We currently do this with editorconfig, maybe we should dedicate an option for this instead. |
Also the user now can change the value, without duplicating the column.
stacyharper
force-pushed
the
better-autowrap-column
branch
from
7160dd2 to
f3615af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the user now can change the value, without duplicating the column.
is based on #5190