Fix logger goroutine leak on restart#159
Merged
Merged
Conversation
mattn
force-pushed
the
fix-logger-goroutine-leak
branch
from
July 8, 2026 01:10
c78ef3f to
20e1b3c
Compare
mattn
force-pushed
the
fix-logger-goroutine-leak
branch
from
July 8, 2026 01:13
20e1b3c to
6162d46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each restart created a new clogger whose goroutine never exits. Reuse the logger stored in procInfo. Adds a leak regression test.