This repository was archived by the owner on Jun 28, 2018. It is now read-only.
feat(cassandra): support for multistatement migrations#280
Closed
JensRantil wants to merge 5 commits intomattes:masterfrom
Closed
feat(cassandra): support for multistatement migrations#280JensRantil wants to merge 5 commits intomattes:masterfrom
JensRantil wants to merge 5 commits intomattes:masterfrom
Conversation
Best-practise according to `gofmt`.
According to `gofmt`.
Golang best-practise. Cleanup made by `gofmt`.
...to be more readable in editor, not just Github.
Unfortunately [1] doesn't support multiple semicolon-separated queries, so they must be executed individually. While this isn't perfect, it covers a lot of cases where one would like to executed multiple statements in a single migration. [1] https://godoc.org/github.com/gocql/gocql#Session.Query
Owner
|
Closing in favor of #276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately [1] doesn't support multiple semicolon-separated queries, so
they must be executed individually. While this isn't perfect, it covers a
lot of cases where one would like to executed multiple statements in a
single migration.
[1] https://godoc.org/github.com/gocql/gocql#Session.Query
Cred to @LarsAlmgren for helping out with this.