Update postgresql testing script

[DMRobertson]

• Use sytest:bionic. Sytest:latest is two years old (do we want
  CI to push out latest at all?) and comes with Python 3.5, which we
  explictly no longer support. The script now runs under PostgreSQL 10
  as a result.
• Pass through argv to tox and trial so we can run specific test(s) in isolation.

A few changes to make it speedier to re-run the tests:

• Create blank DB in the container, not the script, so we don't have to
  initdb each time
• Use a named volume to persist the tox environment, so we don't have to
  fetch and install a bunch of packages from PyPI each time

[DMRobertson]

I just tried this with

scripts-dev/test_postgresql.sh tests.replication.test_sharded_event_persister.EventPersisterShardTestCase

Which took 41 seconds on a re-run. Not bad(?)

[reivilibre]

Thanks, I'm sure this will be useful to many (setting up a postgres locally can be a little bit faffy)

[reivilibre]

One thing worth thinking about: as a user, how can I instruct the testing to run 20 jobs in parallel? I think we might have an ability to do this with an env var: TRIAL_FLAGS="--jobs=20", but you probably need to do special tricks to let that seep into the container?

[DMRobertson]

One thing worth thinking about: as a user, how can I instruct the testing to run 20 jobs in parallel? I think we might have an ability to do this with an env var: TRIAL_FLAGS="--jobs=20", but you probably need to do special tricks to let that seep into the container?

Note that run_pg_tests.sh already has export TRIAL_FLAGS="-j 4" right before it invokes tox

[reivilibre]

Note that run_pg_tests.sh already has export TRIAL_FLAGS="-j 4" right before it invokes tox

ah yes. Slight shame it's not configurable, but don't want to scope creep this if it's not trivial to do

[DMRobertson]

Rerunning the script, I get

• a tox environment owned by me at SYNAPSE_SRC/.tox-pg-container
  • inside that, a virtualenv and tox's logs
• _trial_temp as usual(?), owned by me
• matrix_synapse.egg-info as part of the installation process, owned by me
• no files owned by anyone who isn't me, according to find . -not -uid $(id -u)

[reivilibre]

Thanks!

[reivilibre]

thanks for remembering the docs :)