Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

We accept stupid events over backfill, causing state res storms #3124

@richvdh

Description

@richvdh

If somebody creates an event with hundreds of prev_events, we will (since #3118) reject it when it arrives over federation. However, we may then try to backfill it, and will accept it and do an awful state resolution.

Fixing this is tricky as simply rejecting the event would break back-pagination for the room in question, in the same way that it is currently broken by events which don't have the correct signature (#3121). A solution to #3121 would probably mean that we could also fix this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Messages-Endpoint/messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill)A-Validation500 (mostly) errors due to lack of event/parameter validationz-minor(Deprecated Label)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions