PUT /dehydrated_device is broken and doesn't accept valid requests

[t3chguy]

Description

See matrix-org/matrix-js-sdk#2809
See https://github.com/matrix-org/synapse/pull/14054/files#r1009320711

The PUT API is demanding a device_id body param, which is not part of the MSC. https://github.com/uhoreg/matrix-doc/blob/dehydration/proposals/2697-device-dehydration.md#dehydrating-a-device

Steps to reproduce

• Send valid PUT /dehydrated_device request
• Receive 400 (Bad Request) M_MISSING_PARAM: MatrixError: [400] 1 validation error for PutBody device_id field required (type=value_error.missing) (/_matrix/client/unstable/org.matrix.msc2697.v2/dehydrated_device)

Homeserver

Any

Synapse Version

1.70.0

Installation Method

No response

Platform

Any

Relevant log output

M_MISSING_PARAM: MatrixError: [400] 1 validation error for PutBody device_id field required (type=value_error.missing) (/_matrix/client/unstable/org.matrix.msc2697.v2/dehydrated_device)

Anything else that would be useful to know?

Regressed by #14054

[clokep]

To make it explicit -- this regressed in v1.70.0rc1.

[DMRobertson]

@clokep Are you sure this is a regression? AFAICS from https://github.com/matrix-org/synapse/pull/14054/files?diff=split&w=0#diff-7225331690e55a76b271fbcaf20bed5aaaf69fb5a21b03a9bf297929b157ba1cL300-R333 we were always looking for device_id in the request body.

[t3chguy]

@DMRobertson that's POST, this issue is about PUT

[DMRobertson]

Ahh yes, thanks.