First cut of the a module to derive usernames from 3PIDs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babolivier
added
the
Z-Time-Tracked
Fair, but FWIW I think one of the mypy errors would be fixed by requiring the |
DMRobertson
reviewed
Jan 25, 2022
Ah yeah good point. |
|
For the paper trail, I'm merging despite CI failing since failures are due to the reasons mentioned in the PR description. I've ran the tests and linters/mypy locally with the branch from matrix-org/synapse#11790 checked out and everything's passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is happening in the context of mainlining the fork of Synapse used for Tchap, and migrates an existing feature from the Tchap fork into a module, leveraging the callback and module API added in matrix-org/synapse#11790.
Most of the code in this module has been copied over from https://github.com/matrix-org/synapse-dinsic/blob/d1fedca096250e04c8f1b7101003f3f4cfddea9a/synapse/rest/client/register.py#L622-L670
CI is expected to fail since the callback and module API used haven't been released in Synapse yet.