Skip to content

MSC3783: Fixed base64 for SAS verification #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2023
Merged

MSC3783: Fixed base64 for SAS verification #3783

merged 4 commits into from
Jan 9, 2023

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Apr 25, 2022 •
edited by turt2live
Loading

@uhoreg uhoreg changed the title MSCxxxx: Fixed base64 for SAS verification MSC3783: Fixed base64 for SAS verification Apr 25, 2022
@uhoreg uhoreg mentioned this pull request Apr 25, 2022
Merged
@uhoreg uhoreg marked this pull request as ready for review April 25, 2022 15:17
poljar
poljar reviewed Apr 25, 2022
View reviewed changes
@uhoreg uhoreg added e2e proposal-in-review proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec labels Apr 25, 2022
@poljar poljar mentioned this pull request Apr 25, 2022
Closed
This was referenced Apr 26, 2022
Open
Open
Closed
richvdh
richvdh reviewed Dec 6, 2022
View reviewed changes
@uhoreg
Copy link
Member Author

uhoreg commented Dec 21, 2022

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Dec 21, 2022 •
edited by richvdh
Loading

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Dec 21, 2022
richvdh
richvdh reviewed Jan 3, 2023
View reviewed changes
@mscbot
Copy link
Collaborator

mscbot commented Jan 4, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 4, 2023
@mscbot
Copy link
Collaborator

mscbot commented Jan 9, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 9, 2023
@turt2live turt2live merged commit 9b3f01b into matrix-org:main Jan 9, 2023
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 9, 2023
@uhoreg uhoreg mentioned this pull request Jan 24, 2023
Merged
@uhoreg
Copy link
Member Author

uhoreg commented Jan 24, 2023

Spec PR: matrix-org/matrix-spec#1412

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jan 25, 2023
@uhoreg uhoreg mentioned this pull request Jan 25, 2023
Merged
3 tasks
@uhoreg uhoreg added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 10, 2023
@uhoreg
Copy link
Member Author

uhoreg commented Feb 10, 2023

merged! 🎉

@zecakeh zecakeh mentioned this pull request Feb 10, 2023
Closed
34 tasks
@clokep clokep mentioned this pull request Feb 17, 2023
Closed
8 tasks
@KitsuneRal KitsuneRal mentioned this pull request Apr 16, 2023
Merged
@td-famedly td-famedly mentioned this pull request Dec 6, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar left review comments

@richvdh richvdh richvdh left review comments

Assignees
No one assigned
Labels
client-server Client-Server API e2e kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Workflow
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uhoreg @mscbot @poljar @richvdh @turt2live