-
Notifications
You must be signed in to change notification settings - Fork 326
fix(sdk): Client::sync_once
defaults to reuse previous token
#5522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #5522 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5522 +/- ##
=======================================
Coverage 88.57% 88.57%
=======================================
Files 339 339
Lines 93627 93635 +8
Branches 93627 93635 +8
=======================================
+ Hits 82927 82937 +10
+ Misses 6565 6562 -3
- Partials 4135 4136 +1 ☔ View full report in Codecov by Sentry. |
Client::sync_once
defaults to reuse previous token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for fixing this! Can you add an entry in the matrix_sdk
's CHANGELOG.md
, please? (in the refactor
section, with an annotation that it's a breaking change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missing a CHANGELOG.md
entry, and we'll be good to go 🥳
Signed-off-by: dragonfly1033 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🥳
Fixes #1835.
Introduces a new
SyncToken
enum for theSyncSettings::token
field.The enum has 3 variants: ReusePrevious (default), NoToken, Specific(String).
Some tests were changed to use the old default (NoToken).
Signed-off-by: Shrey Patel [email protected]