Add tests to CI #1080
Merged
Add tests to CI #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuroe
force-pushed
the
manu/TestPlans
branch
2 times, most recently
from
5f8146a to
6aa44f8
Compare
They are still specific to the macOS target but this is so much readable
Nobody will check those builds during weekend. I hope.
GH actions zips for us
They have 2 configurations each. This means 2 different builds which are longer to run because of sanitizer checks. That's why there are triggered only nightly. This setup is advised at https://developer.apple.com/videos/play/wwdc2019/413?time=2270
To indicate there is at least another kind
SBiOSoftWhare
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think CHANGES.md describes all I did:
Test plans are only for the macOS target. I failed to share the same test plan with 2 different targets. When I tried it wanted to execute all tests from MatrixSDKTests-macOS and MatrixSDKTests-iOS, which are the same.
Given that macOS is the preferred and quickest target for dev, I preferred to focus on it. For readiness and simplicity, test plans do not have macOS in their name but there are test plans for this target, not for iOS.
Note that
AllTestsplan which includes integration tests is failing at the moment for many reasons we need to fix. It will be impossible to fully run it because of rate-limiting issue in Synapse that will be fixed in the coming release.In term of CI strategy:
UnitTestsplan andpod lib lintUnitTestsWithSanitizersandAllTestsWithSanitizersplansFYI, a test plan can be selected here: