Explain safety of unsync::OnceCell::get(&self) in more detail#214
Merged
bors[bot] merged 1 commit intomatklad:masterfrom Jan 2, 2023
Merged
Explain safety of unsync::OnceCell::get(&self) in more detail#214bors[bot] merged 1 commit intomatklad:masterfrom
unsync::OnceCell::get(&self) in more detail#214bors[bot] merged 1 commit intomatklad:masterfrom
Conversation
Owner
|
bors r+ Thanks! |
Contributor
|
Build succeeded! And happy new year! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: I'm working on improving my unsafe Rust skills, and figuring out how
once_cellworks is one way to do that. By more elaborately explaining whyunsync::OnceCell::get(&self)is safely implemented, I hope to help others increase their understanding of unsafe Rust as well.(It was not obvious to me at first why
unsync::OnceCell::get(&self)was safe. But I think I figured it out now.)