Skip to content

Fix issues with line breaks and spacing in SVG output. (mathjax/MathJax#3166) #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix issues with line breaks and spacing in SVG output. (mathjax/MathJax#3166) #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ts/output/common/LineBBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export class LineBBox extends BBox {
*/
public append(cbox: LineBBox) {
if (this.isFirst) {
cbox.originalL = cbox.L;
cbox.originalL += cbox.L;
cbox.L = 0; // remove spacing after an operator with a linebreak after it
}
if (cbox.indentData) {
Expand Down
3 changes: 2 additions & 1 deletion ts/output/common/Wrappers/mspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ export function CommonMspaceMixin<
const bbox = LineBBox.from(BBox.zero(), leading);
if (i === 1) {
bbox.getIndentData(this.node);
bbox.isFirst = true;
bbox.w = this.getBBox().w;
bbox.isFirst = (bbox.w === 0);
}
return bbox;
}
Expand Down
4 changes: 2 additions & 2 deletions ts/output/svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,12 +397,12 @@ CommonOutputJax<
if (forced && mo.node.attributes.get('linebreakstyle') === 'after') {
const k = mml.parent.node.childIndex(mml.node) + 1;
const next = mml.parent.childNodes[k];
const dimen = (next ? next.getLineBBox(0).originalL : 0) * scale;
const dimen = (next ? next.getLineBBox(0).originalL * scale : 0);
if (dimen) {
this.addInlineBreak(nsvg, dimen, forced);
}
} else if (forced || i) {
const dimen = (mml && i ? mml.getLineBBox(0).originalL : 0) * scale;
const dimen = (mml && i ? mml.getLineBBox(0).originalL * scale : 0);
if (dimen || !forced) {
this.addInlineBreak(nsvg, dimen, forced || !!mml.node.getProperty('forcebreak'));
}
Expand Down