Skip to content

fix MSVC C++20 module build error C2872, C2039, C2873 on 'literals' #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

fix MSVC C++20 module build error C2872, C2039, C2873 on 'literals' #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 43 additions & 42 deletions src/modules/tomlpp.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

module;

#define TOML_UNDEF_MACROS 0
#include <toml++/toml.hpp>

export module tomlplusplus;
Expand All @@ -19,49 +20,49 @@ export namespace toml {
* @brief The toml++ namespace toml::literals::
*/
inline namespace literals {
using toml::literals::operator""_toml;
using toml::literals::operator""_tpath;
Comment on lines -22 to -23
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marzer @mikomikotaishi I noticed that operator""_toml and operator""_tpath are exported twice.

Here, inside toml::literals:

tomlplusplus/src/modules/tomlpp.cppm

Lines 21 to 24 in fea1d90

inline namespace literals {
using toml::literals::operator""_toml;
using toml::literals::operator""_tpath;
}

And here, at the root of the toml namespace:

tomlplusplus/src/modules/tomlpp.cppm

Lines 62 to 63 in fea1d90

using toml::operator""_toml;
using toml::operator""_tpath;
Was that intended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I thought it would be necessary to re-export the contents of literals, and on my end it compiles fine - but if it is only causing more harm than benefit, perhaps it should be removed entirely? I am not entirely sure what the literals namespace is for myself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikomikotaishi Well, it just isn't clear to me why operator""_toml and operator""_tpath are exported twice (once in toml::literals and once in toml), but if you have a use case that only works when they are exported twice, can you please share it?

Anyway, this pull request already appears to fix those MSVC compile errors on literals, so technically it seems to work, exporting those operators twice.

using TOML_NAMESPACE::literals::operator""_toml;
using TOML_NAMESPACE::literals::operator""_tpath;
}

using toml::array;
using toml::date;
using toml::date_time;
using toml::inserter;
using toml::json_formatter;
using toml::key;
using toml::node;
using toml::node_view;
using toml::parse_error;
using toml::parse_result;
using toml::path;
using toml::path_component;
using toml::source_position;
using toml::source_region;
using toml::table;
using toml::time;
using toml::time_offset;
using toml::toml_formatter;
using toml::value;
using toml::yaml_formatter;
using toml::format_flags;
using toml::node_type;
using toml::path_component_type;
using toml::value_flags;
using toml::array_iterator;
using toml::const_array_iterator;
using toml::const_table_iterator;
using toml::default_formatter;
using toml::inserted_type_of;
using toml::optional;
using toml::source_index;
using toml::source_path_ptr;
using toml::table_iterator;
using TOML_NAMESPACE::array;
using TOML_NAMESPACE::date;
using TOML_NAMESPACE::date_time;
using TOML_NAMESPACE::inserter;
using TOML_NAMESPACE::json_formatter;
using TOML_NAMESPACE::key;
using TOML_NAMESPACE::node;
using TOML_NAMESPACE::node_view;
using TOML_NAMESPACE::parse_error;
using TOML_NAMESPACE::parse_result;
using TOML_NAMESPACE::path;
using TOML_NAMESPACE::path_component;
using TOML_NAMESPACE::source_position;
using TOML_NAMESPACE::source_region;
using TOML_NAMESPACE::table;
using TOML_NAMESPACE::time;
using TOML_NAMESPACE::time_offset;
using TOML_NAMESPACE::toml_formatter;
using TOML_NAMESPACE::value;
using TOML_NAMESPACE::yaml_formatter;
using TOML_NAMESPACE::format_flags;
using TOML_NAMESPACE::node_type;
using TOML_NAMESPACE::path_component_type;
using TOML_NAMESPACE::value_flags;
using TOML_NAMESPACE::array_iterator;
using TOML_NAMESPACE::const_array_iterator;
using TOML_NAMESPACE::const_table_iterator;
using TOML_NAMESPACE::default_formatter;
using TOML_NAMESPACE::inserted_type_of;
using TOML_NAMESPACE::optional;
using TOML_NAMESPACE::source_index;
using TOML_NAMESPACE::source_path_ptr;
using TOML_NAMESPACE::table_iterator;

using toml::at_path;
using toml::get_line;
using toml::operator""_toml;
using toml::operator""_tpath;
using toml::operator<<;
using toml::parse;
using toml::parse_file;
using TOML_NAMESPACE::at_path;
using TOML_NAMESPACE::get_line;
using TOML_NAMESPACE::operator""_toml;
using TOML_NAMESPACE::operator""_tpath;
using TOML_NAMESPACE::operator<<;
using TOML_NAMESPACE::parse;
using TOML_NAMESPACE::parse_file;
}