Undefined references linker error on nvc++

[Tomcat-42]

Environment

toml++ version and/or commit hash:
v3.4.0

Compiler:
nvc++ 23.11:

nvc++ 23.11-0 64-bit target on x86-64 Linux -tp tigerlake
NVIDIA Compilers and Tools
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES.  All rights reserved.

C++ standard mode:
17, 20 and 23

Target arch:
x64

Library configuration overrides:
None.

Relevant compilation flags:
None.

Describe the bug

Every time I try to use the toml::parse_file function I get those undefined references errors:

/usr/bin/ld: build/.objs/simulator/linux/x86_64/release/src/simulator/util/toml.cpp.o: in function `toml::v3::impl::impl_ex::parser::parse_table_header()':                                                                                                                                 
/home/pablo/.xmake/packages/t/toml++/v3.4.0/305579b325f940cbb9bfa2d2a8effc4b/include/toml++/impl/parser.inl:3269:(.text+0x1872c): undefined reference to `toml::v3::node::is_table() const'                                                                                                 
/usr/bin/ld: /home/pablo/.xmake/packages/t/toml++/v3.4.0/305579b325f940cbb9bfa2d2a8effc4b/include/toml++/impl/parser.inl:3269:(.text+0x18738): undefined reference to `toml::v3::node::is_array_of_tables() const'              

Steps to reproduce (or a small repro code sample)

./example.toml

key = "val"

./main.cpp:

#include <iostream>

#include "toml.hpp"

int main() {
  toml::table t = toml::parse_file("example.toml");
  std::cout << t << std::endl;
}

./toml.hpp:
toml v3.4.0 header

Additional information

Perhaps is something related to #198?

[marzer]

Huh, this is a weird one. Are you using the library in "header-only" mode (the default if the header is standalone), or precompiled?

[Tomcat-42]

I'm using in Header Only mode.

[marzer]

Would you mind testing the "precompiled" mode for me by disabling TOML_HEADER_ONLY? See the "Speeding up compilation" section of the main page for details.

[Tomcat-42]

The error continues:

/usr/bin/ld: /tmp/nvc++dx_jAYPPLLB.o: in function `toml::v3::toml_formatter::print_inline(toml::v3::table const&)':
/home/pablo/test/toml.hpp:17045:(.text+0x29aba): undefined reference to `toml::v3::node::type() const'
/usr/bin/ld: /tmp/nvc++dx_jAYPPLLB.o: in function `toml::v3::toml_formatter::print(toml::v3::table const&)':
/home/pablo/test/toml.hpp:17137:(.text+0x29faf): undefined reference to `toml::v3::node::type() const'
/usr/bin/ld: /home/pablo/test/toml.hpp:17173:(.text+0x2a1bd): undefined reference to `toml::v3::node::type() const'
/usr/bin/ld: /home/pablo/test/toml.hpp:17186:(.text+0x2a2ac): undefined reference to `toml::v3::node::type() const'
/usr/bin/ld: /tmp/nvc++dx_jAYPPLLB.o: in function `toml::v3::json_formatter::print(toml::v3::table const&)':
/home/pablo/test/toml.hpp:17345:(.text+0x2ab13): undefined reference to `toml::v3::node::type() const'
/usr/bin/ld: /tmp/nvc++dx_jAYPPLLB.o:/home/pablo/test/toml.hpp:17510: more undefined references to `toml::v3::node::type() const' follow
/usr/bin/ld: /tmp/nvc++dx_jAYPPLLB.o: in function `toml::v3::impl::impl_ex::parser::parse_table_header()':
/home/pablo/test/toml.hpp:15714:(.text+0x38520): undefined reference to `toml::v3::node::is_table() const'
/usr/bin/ld: /home/pablo/test/toml.hpp:15714:(.text+0x3853d): undefined reference to `toml::v3::node::is_array_of_tables() const'

[Tomcat-42]

I have created a docker image for reproducing my exact issue on my environment:

docker run -it tomcat0x42/toml-ex bash

And then, inside the container:

cd /home/builder/toml_ex/ && ./build 

(sorry for the image size, all things NVIDIA™ are always bloated.)

[marzer]

Great! Very helpful, thanks. I'll try to make use of it soon.

Nvidia's toolchain has caused me nothing but misery, honestly.

[Tomcat-42]

Nvidia's toolchain has caused me nothing but misery, honestly.

Yes, last week I had the most fierce battle of my entire career with a compiler (nvc++), and it was just a -cuda flag on the linker.

[marzer]

Haha, of course. What's some compiler bullshit without a missing (and woefully under-documented) flag?

[Tomcat-42]

Hello @marzer , did you got a chance of looking at this issue?

[marzer]

@Tomcat-42 I've pulled your image and reproduced it for myself, but that's about all I've had time for. Have been travelling for work the last couple of weeks. Been hoping to make time for it some evening this week though :)

[marzer]

Oh, thought I was reproducing it. Just playing with it now and what I was actually seeing was that the way you've used TOML_HEADER_ONLY and TOML_IMPLEMENTATION in the image isn't correct; you've put TOML_IMPLEMENTATION after the point at which toml++ is transitively included, so from it's perpsective the implementation is always disabled (because TOML_HEADER_ONLY has been set to 0 beforehand).

Doesn't solve the issue, after addressing it I am seeing the weird stuff you are above 😅 Just thought you may want to double-check that against any "concrete" implementations you have on the go.

[marzer]

Curiously, every function exhibiting this issue is pure virtual in the base. Looks like some vtable shenanigans.

[marzer]

@Tomcat-42 Right, after much hoop-jumping trying to get a working version of nvhpc installed on my linux laptop, I had some time to experiment with this a bit more comprehensively. Can you try the workaround I've implemented in 1f7884e?