Flash Gated Delta Rule kernels in Pallas #1292
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calvin/gated_deltanet_sharding_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR adds "flash" implementations of recurrent and chunk gated delta rules, based on the Triton kernels from https://github.com/fla-org/flash-linear-attention. Notable improvements are:
(num_heads, num_V_tiles)grid, with K dim tiled internally in a loopExisting tests were parameterized with
@pytest.mark.parametrize("use_flash", [True, False])and all pass on CPUpl.pallas_call(..., interpret=True). Additional work is in progress to 1. make them work correctly on TPUs (https://docs.jax.dev/en/latest/pallas/tpu/index.html) and 2. refactor and cleanup, in particular move the flash code to a separate file.