Skip to content

Fix some more typos #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from
Open

Fix some more typos #291

wants to merge 1 commit into from

Conversation

qobood
Copy link
Contributor

@qobood qobood commented Jul 31, 2025

No description provided.

@qobood
Copy link
Contributor Author

qobood commented Jul 31, 2025

Hi @9E0R9!
I have two questions:
There is a typo in variable name (cssl) in libmariadb/mariadb_async.c below #ifdef HAVE_TLS_FIXME. This part hasn't been touched since 2016, should it still be changed?
And another question - while testing I've bumped into a client crash because of lack of checks for NULL in mariadb_lib.c. I've submitted the bugreport:
https://jira.mariadb.org/browse/MDEV-37034
and it got closed. I'd still like to add appropriate checks. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@qobood