Prepare linter for golangci-lint #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Described False-Negative cases as testcases and in README.md 3. Fixed link for type_nested.go.skip in README.md 4. Added testcase with generic 5. Added testcase with alias 6. Added testcase with map, chan, array, func
Owner
Author
|
@Antonboom I fixed all except type OtherStruct struct {}
type Struct struct {
Other OtherStruct
}
func NewStruct() Struct {
return Struct{
Other: OtherStruct{}, // warning?
}
}I described this in README.md (Possible Features). I added testcases |
maranqz
commented
Nov 16, 2023
README.md
Outdated
|
|
||
| - `-b`, `--blockedPkgs` - list of packages, where the structures should be created by factories. By default, all structures in all packages should be created by factories, [tests](testdata/src/factory/blockedPkgs). | ||
| - `-ob`, `onlyBlockedPkgs` - only blocked packages should use factory to initiate struct, [tests](testdata/src/factory/onlyBlockedPkgs). | ||
| - `-pg`, `--pkgGlobs` - list of glob packages, which can contain factories for structures in prefix. By default, all structures in all packages should be created by factories, [tests](testdata/src/factory/pkgGlobs). |
Owner
Author
There was a problem hiding this comment.
Bump major version for linter
2. Renamed options
maranqz
force-pushed
the
golangci-lint-pr
branch
from
00fa4ab to
045a0fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on golangci/golangci-lint#4196 (review)