Handle place picker dialog on configuration change #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsnow1
requested changes
Mar 17, 2017
| public class PlaceDialogFragment extends DialogFragment implements DialogInterface.OnClickListener { | ||
| public static final String TAG = PlaceDialogFragment.class.getSimpleName(); | ||
|
|
||
| private static final String ARG_NAME_TITLE = "title"; |
There was a problem hiding this comment.
To be more consistent with the property set on the dialog and with the setMessage method, we should change this to ARG_NAME_MESSAGE
There was a problem hiding this comment.
Good call. Updated!
| * @param title text to be displayed in the dialog. | ||
| * @return a new instance of the dialog fragment. | ||
| */ | ||
| public static PlaceDialogFragment newInstance(String title) { |
There was a problem hiding this comment.
Related to above, we should change the param name from title to message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Properly handle place picker dialog on configuration change so state is persisted and dialog is not leaked.
Proposed Changes
AlertDialogto aDialogFragmentto maintain view state.PlaceStoresingleton to persist current selection data through configuration change whenPlacePickerPresenteris destroyed and recreated along withPlacePickerActivity.Fixes #324