Add Etag support to the coming vector/geojson worker refactor.#7074
Open
wayofthefuture wants to merge 20 commits intomainfrom
Open
Add Etag support to the coming vector/geojson worker refactor.#7074wayofthefuture wants to merge 20 commits intomainfrom
wayofthefuture wants to merge 20 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## geojson-worker-abstract #7074 +/- ##
========================================================
Coverage 92.57% 92.58%
========================================================
Files 289 289
Lines 23987 24002 +15
Branches 5083 5088 +5
========================================================
+ Hits 22206 22222 +16
+ Misses 1781 1780 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HarelM
reviewed
Feb 7, 2026
8 tasks
Collaborator
|
@wayofthefuture I'll let you handle this merge, I tried it myself but was not 100% sure... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR against the current PR #7058 that creates more separation between vector and geojson workers. Putting up this draft PR so we can visualize the differences (and show patch coverage) between the new refactored workers and the coming etag support, which is modifying many of the same files. Feel free to comment. Am trying to figure out the best way to abstract the vector/geojson workers from each other while maintaining the coming etag support in a clean way.
The etag support in this PR tries to leverage the existing workertile result pipeline, and adds a LoadTileResult type to loadTile - which carries an etagUnmodified property. I figured this result type would be beneficial as it allows further properties to be added in the future to loadTile. In order to separate downloading from tile creation (for etag), the network request and creation of the vector tile data are separated so that when the etag hasn't changed the processing does not occur. Coincidentally now both loadVectorTile's in both workers are synchronous and separate tile processing from any network requests.