Skip to content

Modify RegEx to support finding parent commit ID when GitWeb is using pathinfo formatted URLs #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

achmafooma
Copy link
Contributor

Gitweb can be configured to use pathinfo URLs with the gitweb.conf setting $feature{'pathinfo'}{'default'} = [1]; and appropriate .htaccess changes.

In this configuration, the URLs are prettier. For example, a 'standard' Gitweb URL like this:

https://git.example.com/?p=project.git;a=commit;h=hash_goes_here

Will change to this:

https://git.example.com/project.git/commit/hash_goes_here

SourceGitweb uses RegEx to find the parent hash for a commit. The current RegEx string only works when Gitweb is creating the links on the page with 'standard' URLs. If you try to import commits from a Gitweb instance that is using pathinfo URLs, it only imports one commit (most recent) and stops there because it can't find any parents.

I have modified the RegEx string so it can find the parent hashes in both Gitweb URL modes.

@dregad dregad added this to the 2.9.0 milestone Jan 17, 2025
@dregad dregad merged commit 2b8b7a9 into mantisbt-plugins:master Jan 17, 2025
@dregad
Copy link
Member

dregad commented Jan 17, 2025

Thanks for your contribution!

@achmafooma
Copy link
Contributor Author

Thanks for your contribution!

You're very welcome! Glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants