Modify RegEx to support finding parent commit ID when GitWeb is using pathinfo formatted URLs #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitweb can be configured to use pathinfo URLs with the gitweb.conf setting
$feature{'pathinfo'}{'default'} = [1];
and appropriate.htaccess
changes.In this configuration, the URLs are prettier. For example, a 'standard' Gitweb URL like this:
https://git.example.com/?p=project.git;a=commit;h=hash_goes_here
Will change to this:
https://git.example.com/project.git/commit/hash_goes_here
SourceGitweb uses RegEx to find the parent hash for a commit. The current RegEx string only works when Gitweb is creating the links on the page with 'standard' URLs. If you try to import commits from a Gitweb instance that is using pathinfo URLs, it only imports one commit (most recent) and stops there because it can't find any parents.
I have modified the RegEx string so it can find the parent hashes in both Gitweb URL modes.