SVN: support svn:log revprop changes #305
Conversation
Add rudimentary support for svn:log revprop changes to permit SCI to keep repositories current when you have developers that don't always get commit messages right first time. Doesn't deal with reopening "accidentally closed" issues.
|
I suppose this is a refresh of #84 ? |
|
Pretty much, yes. I pulled mantisbt-plugins/source-integration:master and banged #84 until it fitted/worked. |
There was a problem hiding this comment.
I'm concerned that your approach would introduce regression issues for other VCS plugins.
Instead of changing the core, it would probably be better to have the SourceSVN plugin hook into the SOURCE_PRECOMMIT event, and handle the extra reprop parameter there.
You can have a look at how the SourceGithub uses this mechanism, to retrieve an extra post parameter and process payload in the message body.
|
Thanks for the feedback. Will take on board and "resubmit". |
Signature of function commit() restored, gpc value is detected directly. Output strings localized. Indentation corrected.
|
@pantsmanuk This looks good to me, but I don't use SVN so I can't test. I assume you have done so yourself, so let's just give a few days for other users to provide feedback before merging. |
Changed the boolean "if($t_revprop==false)" to the more "normal" "if(!$t_revprop)"
Add rudimentary support for svn:log revprop changes to permit SCI to keep
repositories current when you have developers that don't always get commit
messages right first time. Doesn't deal with reopening "accidentally closed"
issues.