feat(lint): add dedicated selector regex validation phase#66
Merged
ghaskins merged 1 commit intomanetu:mainfrom Apr 8, 2026
Merged
feat(lint): add dedicated selector regex validation phase#66ghaskins merged 1 commit intomanetu:mainfrom
ghaskins merged 1 commit intomanetu:mainfrom
Conversation
Previously, invalid regex patterns in operation/mapper/resource selector fields were only caught by the parser, surfacing as a generic "failed to load PolicyDomain" error with no entity context or line info. This adds a new Phase 1.5 (lintSelectors) that walks the YAML node tree and validates each selector pattern individually, emitting structured Diagnostic entries with entity type, ID, Field="selector", and the exact YAML line number of the offending pattern. Introduces SourceSelector as a new diagnostic source constant and covers the new phase with 19 tests across unit and integration paths. Signed-off-by: Greg Haskins <greg@manetu.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, invalid regex patterns in operation/mapper/resource selector fields were only caught by the parser, surfacing as a generic "failed to load PolicyDomain" error with no entity context or line info.
This adds a new Phase 1.5 (lintSelectors) that walks the YAML node tree and validates each selector pattern individually, emitting structured Diagnostic entries with entity type, ID, Field="selector", and the exact YAML line number of the offending pattern.
Introduces SourceSelector as a new diagnostic source constant and covers the new phase with 19 tests across unit and integration paths.