Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Greg Haskins <greg@manetu.com>
Regal uses OPA's crypto.md5 builtin internally in its own Rego rules. Under GODEBUG=fips140=only, Go's crypto/md5 panics. Because the panic originates in a goroutine spawned by Regal's errgroup, a defer/recover in the caller cannot catch it. Detect FIPS mode via GODEBUG and skip Regal linting with a warning. Skip the TestPerformRegalLinting_InvalidRego test in FIPS mode, as it asserts Regal-specific error codes that are never reached when linting is bypassed. Signed-off-by: Greg Haskins <greg@manetu.com>
exec.Command with individual args does not invoke a shell, so there is no injection risk. The opaFlags value comes from operator-supplied CLI flags or environment variables, not untrusted external input. Signed-off-by: Greg Haskins <greg@manetu.com>
Signed-off-by: Greg Haskins <greg@manetu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.