Skip to content

chore: try make bindings sync work on forks #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2025

Conversation

makspll
Copy link
Owner

@makspll makspll commented Jul 6, 2025

Summary

The synchronisation flow is very useful for the main repo, but does nothing for forks, I'd like people to know when they need to synchronize the codegenned code at the very least, at some point the diff could even be automatically applied but that requires my own token in the action I believe

Copy link

semanticdiff-com bot commented Jul 6, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  .github/workflows/synchronize_bindings.yml  18% smaller
  .github/workflows/synchronize_bindings_check_diff.yml  5% smaller

@makspll makspll changed the title try make bindings sync work on forks chore: try make bindings sync work on forks Jul 6, 2025
Copy link
Contributor

github-actions bot commented Jul 6, 2025

🐰 Bencher Report

Branchfix/improve-bindings-sync-action
Testbedlinux-gha

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
component/access Lua📈 view plot
⚠️ NO THRESHOLD
3,492.50 ns
component/access Rhai📈 view plot
⚠️ NO THRESHOLD
4,940.30 ns
component/get Lua📈 view plot
⚠️ NO THRESHOLD
2,155.40 ns
component/get Rhai📈 view plot
⚠️ NO THRESHOLD
3,662.80 ns
conversions/Mut::from📈 view plot
⚠️ NO THRESHOLD
79.95 ns
conversions/Ref::from📈 view plot
⚠️ NO THRESHOLD
80.01 ns
conversions/ScriptValue::List📈 view plot
⚠️ NO THRESHOLD
279.78 ns
conversions/ScriptValue::Map📈 view plot
⚠️ NO THRESHOLD
1,240.40 ns
conversions/ScriptValue::Reference::from_into📈 view plot
⚠️ NO THRESHOLD
25.83 ns
conversions/Val::from_into📈 view plot
⚠️ NO THRESHOLD
254.45 ns
function/call 4 args Lua📈 view plot
⚠️ NO THRESHOLD
1,640.70 ns
function/call 4 args Rhai📈 view plot
⚠️ NO THRESHOLD
1,293.00 ns
function/call Lua📈 view plot
⚠️ NO THRESHOLD
245.38 ns
function/call Rhai📈 view plot
⚠️ NO THRESHOLD
382.48 ns
loading/empty Lua📈 view plot
⚠️ NO THRESHOLD
47,409.00 ns
loading/empty Rhai📈 view plot
⚠️ NO THRESHOLD
666,400.00 ns
math/vec mat ops Lua📈 view plot
⚠️ NO THRESHOLD
6,381.70 ns
math/vec mat ops Rhai📈 view plot
⚠️ NO THRESHOLD
6,077.90 ns
query/10 entities Lua📈 view plot
⚠️ NO THRESHOLD
18,544.00 ns
query/10 entities Rhai📈 view plot
⚠️ NO THRESHOLD
17,245.00 ns
query/100 entities Lua📈 view plot
⚠️ NO THRESHOLD
38,465.00 ns
query/100 entities Rhai📈 view plot
⚠️ NO THRESHOLD
31,931.00 ns
query/1000 entities Lua📈 view plot
⚠️ NO THRESHOLD
241,750.00 ns
query/1000 entities Rhai📈 view plot
⚠️ NO THRESHOLD
151,250.00 ns
reflection/10 Lua📈 view plot
⚠️ NO THRESHOLD
5,626.00 ns
reflection/10 Rhai📈 view plot
⚠️ NO THRESHOLD
15,176.00 ns
reflection/100 Lua📈 view plot
⚠️ NO THRESHOLD
50,949.00 ns
reflection/100 Rhai📈 view plot
⚠️ NO THRESHOLD
642,420.00 ns
resource/access Lua📈 view plot
⚠️ NO THRESHOLD
3,042.30 ns
resource/access Rhai📈 view plot
⚠️ NO THRESHOLD
4,249.00 ns
resource/get Lua📈 view plot
⚠️ NO THRESHOLD
1,731.60 ns
resource/get Rhai📈 view plot
⚠️ NO THRESHOLD
3,050.70 ns
🐰 View full continuous benchmarking report in Bencher

@makspll makspll merged commit 67c5a5d into main Jul 6, 2025
20 checks passed
@makspll makspll deleted the fix/improve-bindings-sync-action branch July 6, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant