Skip to content

chore: improve xtask integration with vscode #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2025
Merged

Conversation

makspll
Copy link
Owner

@makspll makspll commented Jul 6, 2025

Summary

for a while there was a problem with using vscode and xtask,

specifically we override the check command to be xtask, but we do not do the same for the build command for macros, this somehow worked for a while, but I've recently run into more issue with it on the bevy 0.16 branch.

I finally put this issue to bed by:

  • fixing a bug where the checks invoked per workspace, would actually run ALL WORKSPACE checks, which was slowing things down and confusing error logs
  • extracting xtask so that it can be checked with a different command to remove loops from the system

I think the fact bevy_api_gen is a separate workspace nested inside the main workspace is a bit weird, so eventually after all the active PR's are merged, I will change the layout of things

Copy link

semanticdiff-com bot commented Jul 6, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/bevy_api_gen/src/passes/cache_traits.rs  100% smaller
  xtask/src/main.rs  17% smaller
  .cargo/config.toml Unsupported file format
  Cargo.toml Unsupported file format
  check.ps1 Unsupported file format
  check.sh Unsupported file format
  codegen_bevy_features.txt Unsupported file format
  xtask/Cargo.toml Unsupported file format
  xtask/Dockerfile Unsupported file format
  xtask/chef.Dockerfile Unsupported file format
  xtask/readme.md Unsupported file format
  xtask/templates/settings.json.tera Unsupported file format

@makspll makspll enabled auto-merge (squash) July 6, 2025 19:47
Copy link
Contributor

github-actions bot commented Jul 6, 2025

🐰 Bencher Report

Branchfix/xtask-for-real
Testbedlinux-gha

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
component/access Lua📈 view plot
⚠️ NO THRESHOLD
3,583.60 ns
component/access Rhai📈 view plot
⚠️ NO THRESHOLD
5,820.70 ns
component/get Lua📈 view plot
⚠️ NO THRESHOLD
2,225.70 ns
component/get Rhai📈 view plot
⚠️ NO THRESHOLD
4,560.20 ns
conversions/Mut::from📈 view plot
⚠️ NO THRESHOLD
79.36 ns
conversions/Ref::from📈 view plot
⚠️ NO THRESHOLD
77.87 ns
conversions/ScriptValue::List📈 view plot
⚠️ NO THRESHOLD
298.26 ns
conversions/ScriptValue::Map📈 view plot
⚠️ NO THRESHOLD
1,159.40 ns
conversions/ScriptValue::Reference::from_into📈 view plot
⚠️ NO THRESHOLD
26.23 ns
conversions/Val::from_into📈 view plot
⚠️ NO THRESHOLD
254.66 ns
function/call 4 args Lua📈 view plot
⚠️ NO THRESHOLD
1,686.60 ns
function/call 4 args Rhai📈 view plot
⚠️ NO THRESHOLD
1,299.00 ns
function/call Lua📈 view plot
⚠️ NO THRESHOLD
228.82 ns
function/call Rhai📈 view plot
⚠️ NO THRESHOLD
373.84 ns
loading/empty Lua📈 view plot
⚠️ NO THRESHOLD
49,321.00 ns
loading/empty Rhai📈 view plot
⚠️ NO THRESHOLD
701,610.00 ns
math/vec mat ops Lua📈 view plot
⚠️ NO THRESHOLD
6,567.80 ns
math/vec mat ops Rhai📈 view plot
⚠️ NO THRESHOLD
6,006.30 ns
query/10 entities Lua📈 view plot
⚠️ NO THRESHOLD
19,435.00 ns
query/10 entities Rhai📈 view plot
⚠️ NO THRESHOLD
21,056.00 ns
query/100 entities Lua📈 view plot
⚠️ NO THRESHOLD
38,626.00 ns
query/100 entities Rhai📈 view plot
⚠️ NO THRESHOLD
31,238.00 ns
query/1000 entities Lua📈 view plot
⚠️ NO THRESHOLD
254,390.00 ns
query/1000 entities Rhai📈 view plot
⚠️ NO THRESHOLD
158,240.00 ns
reflection/10 Lua📈 view plot
⚠️ NO THRESHOLD
5,492.90 ns
reflection/10 Rhai📈 view plot
⚠️ NO THRESHOLD
15,015.00 ns
reflection/100 Lua📈 view plot
⚠️ NO THRESHOLD
48,643.00 ns
reflection/100 Rhai📈 view plot
⚠️ NO THRESHOLD
721,750.00 ns
resource/access Lua📈 view plot
⚠️ NO THRESHOLD
3,158.70 ns
resource/access Rhai📈 view plot
⚠️ NO THRESHOLD
5,213.80 ns
resource/get Lua📈 view plot
⚠️ NO THRESHOLD
1,796.20 ns
resource/get Rhai📈 view plot
⚠️ NO THRESHOLD
3,960.90 ns
🐰 View full continuous benchmarking report in Bencher

@makspll makspll merged commit 92d99fd into main Jul 6, 2025
21 checks passed
@makspll makspll deleted the fix/xtask-for-real branch July 6, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant