Skip to content

feat: Use the Handles, Luke! #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat: Use the Handles, Luke! #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3430b92
hack: It compiles.
shanecelis Jun 27, 2025
cf4dbf4
hack: Compile with lua54 feature.
shanecelis Jun 27, 2025
c3a7d96
refactor: Accept Handle<ScriptAsset> in ScriptComponents.
shanecelis Jun 27, 2025
324f9f3
feature: Handle static scripts.
shanecelis Jun 27, 2025
2636295
bug: Fix rhea and static script unloading.
shanecelis Jun 27, 2025
d6ea7a7
feature: Add ScriptSetttings to loader.
shanecelis Jun 27, 2025
a2c427a
test: Prep tests to run.
shanecelis Jun 27, 2025
13d3514
feature: Add DisplayProxy. Refactor continues.
shanecelis Jun 27, 2025
3a61256
refactor: Bring test harness in line.
shanecelis Jun 28, 2025
4b3ade0
test: Tests are running!
shanecelis Jun 28, 2025
77ce7a9
test: Make test runnable without rhai.
shanecelis Jun 28, 2025
84f5095
excise: Remove ScriptMetadata and ScriptEvent.
shanecelis Jun 28, 2025
2450f15
excise: Drop Script::asset field.
shanecelis Jun 28, 2025
8d6d300
Merge branch 'main' into use-handles
makspll Jun 28, 2025
e0fa423
perf: Can create_or_update_script w/o clone.
shanecelis Jun 28, 2025
db83951
feature: Try to use the entities.
shanecelis Jun 28, 2025
42d54b0
hack: It compiles but idk why.
shanecelis Jun 28, 2025
82cd159
hack: Compiles but doesn't run well.
shanecelis Jun 28, 2025
bb1372f
feature: Use SharedContext(P::C) for global context.
shanecelis Jun 29, 2025
a56f582
feature: GOL works with SharedContext.
shanecelis Jun 29, 2025
ba60f2e
feature: Works with ScriptContextProvider trait.
shanecelis Jun 29, 2025
6b819b3
refactor: It's all coming together now.
shanecelis Jun 29, 2025
e9c4e17
bug: Make per-entity work with static scripts.
shanecelis Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ name = "game_of_life"
path = "examples/game_of_life.rs"
required-features = [
"lua54",
"rhai",
# "rhai",
"bevy/file_watcher",
"bevy/multi_threaded",
]
Expand Down
1 change: 1 addition & 0 deletions crates/bevy_mod_scripting_core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ fixedbitset = "0.5"
petgraph = "0.6"
bevy_mod_debugdump = "0.12"
bevy_system_reflection = { path = "../bevy_system_reflection", version = "0.1.1" }
serde = { version = "1.0", features = ["derive"] }

[dev-dependencies]
test_utils = { workspace = true }
Expand Down
Loading