Add fa (Farsi or Persian) locale translations
#7452
Conversation
WalkthroughThe changes introduce Persian ("fa") language support by adding it to the supported languages list, updating the type definitions, and including new localization files for accessibility and editor components. The accessibility file contains Persian ARIA labels, while the editor file is currently empty. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant I18nModule
User->>UI: Selects Persian language ("fa")
UI->>I18nModule: Request translations for "fa"
I18nModule->>I18nModule: Loads fa/accessibility.json and fa/editor.json
I18nModule-->>UI: Provides Persian translations
UI-->>User: Displays UI in Persian
Estimated code review effort1 (~2 minutes) Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
|
I couldn't find the type definition file and language constant as described in the Adding new languages section of the documentation. Please tell me where they are. |
|
I made all the necessary changes to the codebase in the following routes:
I hereby request review and merge. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/i18n/src/locales/fa/editor.json (1)
1-1: Empty placeholder may surface as missing labels
editor.jsonis an empty object. Unless the runtime gracefully falls back to English, users will see blank strings. Consider populating the keys or omitting the file until translations are ready.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/i18n/src/constants/language.ts(1 hunks)packages/i18n/src/locales/fa/accessibility.json(1 hunks)packages/i18n/src/locales/fa/editor.json(1 hunks)packages/i18n/src/types/language.ts(1 hunks)
🧠 Learnings (4)
📓 Common learnings
Learnt from: janreges
PR: makeplane/plane#6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
packages/i18n/src/constants/language.ts (1)
Learnt from: janreges
PR: #6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
packages/i18n/src/locales/fa/accessibility.json (1)
Learnt from: vamsikrishnamathala
PR: #7092
File: web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/root.tsx:109-113
Timestamp: 2025-05-22T11:21:49.370Z
Learning: Both translation keys "sub_work_item.empty_state.list_filters.action" and "sub_work_item.empty_state.sub_list_filters.action" have identical values across all language files in the Plane project, so they can be used interchangeably.
packages/i18n/src/types/language.ts (1)
Learnt from: janreges
PR: #6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
🪛 Biome (1.9.4)
packages/i18n/src/types/language.ts
[error] 21-21: Expected a statement but instead found '| "fa"'.
Expected a statement here.
(parse)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: janreges
PR: makeplane/plane#6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
packages/i18n/src/constants/language.ts (1)
Learnt from: janreges
PR: #6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
packages/i18n/src/locales/fa/accessibility.json (1)
Learnt from: vamsikrishnamathala
PR: #7092
File: web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/root.tsx:109-113
Timestamp: 2025-05-22T11:21:49.370Z
Learning: Both translation keys "sub_work_item.empty_state.list_filters.action" and "sub_work_item.empty_state.sub_list_filters.action" have identical values across all language files in the Plane project, so they can be used interchangeably.
packages/i18n/src/types/language.ts (1)
Learnt from: janreges
PR: #6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
🪛 Biome (1.9.4)
packages/i18n/src/types/language.ts
[error] 21-21: Expected a statement but instead found '| "fa"'.
Expected a statement here.
(parse)
🔇 Additional comments (2)
packages/i18n/src/constants/language.ts (1)
25-25: Ensure RTL handling for PersianPersian is right-to-left. If the app maintains a list like
RTL_LANGUAGESor a direction flag, add"fa"there to avoid layout issues.packages/i18n/src/locales/fa/accessibility.json (1)
1-34: Accessibility translations look goodJSON structure is valid and key set matches other locales. No issues spotted.
|
I'd be grateful if the reviewers take a look at this PR. |
Description
Followed the instructions on Contributing to language support to add the
fa(Farsi or Persian) locale. I mostly used the French and English versions.Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit