Skip to content

Conversation

@pquan
Copy link

@pquan pquan commented Sep 25, 2025

Contribution Guidelines

What does this PR include?

Short Description

This PR enables saving the quarantine history(queue) for domains that are only relayed and have no local mailboxes. The admin or the domain admin can manage the quarantine and release / delete etc. messages.

This is an implementation of the enhancement request #5325

As a side note, it fixes a typo in a SQL query in pipe.php (no change of funcionality there).

Affected Containers

  • rspamd (for metadata export)
  • web (for the functions.inc.php) mods.

Did you run tests?

Yes. Using it live.

What did you tested?

Queue comes up. The admin can do all operations. Also a domain admin can do all operation.

What were the final results? (Awaited, got)

It works as expected.

@DerLinkman DerLinkman added the not matching contrib guidelines Whenever a issue/pr is not matching the Guidelines this tag will assigned label Oct 2, 2025
@DerLinkman
Copy link
Member

Please rebase pr against staging, not master.

Read contribution.md for more informations

@pquan
Copy link
Author

pquan commented Oct 2, 2025

I see it rebased on staging... There's a successful check below for that.
Am I missing something ?
immagine

@patschi
Copy link
Member

patschi commented Oct 7, 2025

Maybe it wasn't when raising PR? Maybe try force-push on it, alternatively re-create straight against staging. Because above commit list contains plenty of unrelated, old commits (which usually is the cause when not going against right branch)

@pquan pquan force-pushed the relay-quarantine branch from 31cd826 to fc6be3d Compare October 8, 2025 10:08
@pquan pquan marked this pull request as draft October 8, 2025 10:18
@pquan pquan closed this Oct 8, 2025
@pquan pquan force-pushed the relay-quarantine branch from fc6be3d to df4d3bb Compare October 8, 2025 17:12
…g quarantined mail into the domain administrator queue
@pquan pquan reopened this Oct 8, 2025
@pquan
Copy link
Author

pquan commented Oct 8, 2025

Sorry for the fuss. I updated the PR based on staging. It shows now a single 2 file commit.
It is ready for review now. I hope it can be merged without futher problems.
Thank you @patschi @DerLinkman

@pquan pquan marked this pull request as ready for review October 8, 2025 17:27
@patschi patschi removed the not matching contrib guidelines Whenever a issue/pr is not matching the Guidelines this tag will assigned label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants