xdg-toplevel: store states as a bit mask #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the xdg-toplevel state management from using an AHashSet<u32> to a bitmask stored in a NumCell<u32>. This provides more efficient state storage and operations.
- Introduced
state_bits()helper function to convert state values to bit positions - Replaced set operations (insert/remove/contains) with bitwise operations (or_assign/and_assign/contains)
- Updated initialization logic to conditionally set tiled states based on protocol version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mahkoh
force-pushed
the
jorth/toplevel-bitmask
branch
from
5040bc2 to
0d844ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.