Skip to content

Conversation

@mahkoh
Copy link
Owner

@mahkoh mahkoh commented Dec 18, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the WlKeyboard struct to store client and version fields directly instead of accessing them through the seat field. This is a cleanup that reduces indirection and simplifies the code.

  • Adds client and version fields to WlKeyboard struct, initialized from the parent seat
  • Updates all methods to access client and version directly instead of through self.seat
  • Changes method signatures from &self to self: &Rc<Self> where needed

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/ifs/wl_seat/wl_keyboard.rs Adds client and version fields to WlKeyboard, updates method signatures, and replaces self.seat.client/self.seat.version with direct field access
src/ifs/wl_seat/zwp_virtual_keyboard_v1.rs Updates for_each_kb closure signature to accept &Rc<WlKeyboard> instead of &WlKeyboard to match new method signatures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahkoh mahkoh merged commit 302a4fb into master Dec 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants