Skip to content

Conversation

@mahkoh
Copy link
Owner

@mahkoh mahkoh commented Dec 18, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR regenerates wire protocol files from the wayland.xml specification, standardizing their format and adding semantic metadata. The changes systematically improve the structure and clarity of the wire protocol definitions.

  • Removes # requests and # events section header comments
  • Adds semantic attributes like (destructor) and (new) to requests/events and parameters
  • Reorganizes content with consistent ordering and formatting

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
wire/wl_touch.txt Removes section headers, adds (destructor) to release request, reorders events before requests
wire/wl_surface.txt Adds (destructor) and (new) attributes, moves enter/leave events before versioned requests
wire/wl_subsurface.txt Removes section headers, adds (destructor) to destroy, normalizes formatting
wire/wl_subcompositor.txt Adds (destructor) and (new) attributes, removes section headers
wire/wl_shm_pool.txt Adds (new) and (destructor) attributes, removes section headers
wire/wl_shm.txt Adds (new) and (destructor) attributes, reorders release request after event
wire/wl_seat.txt Adds (new) and (destructor) attributes, moves capabilities event to top
wire/wl_registry.txt Removes section headers only
wire/wl_region.txt Removes section headers, adds (destructor) attribute
wire/wl_pointer.txt Adds (destructor) attribute, removes section headers, reorders release request
wire/wl_output.txt Normalizes parameter formatting, adds (destructor) attribute, reorders release request
wire/wl_keyboard.txt Adds (destructor) attribute, removes section headers, reorders release request
wire/wl_fixes.txt Adds (destructor) attribute, removes empty line
wire/wl_display.txt Adds (new) attributes, removes section headers
wire/wl_data_source.txt Adds (destructor) attribute, reorders set_actions request after cancelled event
wire/wl_data_offer.txt Adds (destructor) attribute, moves offer event before versioned requests
wire/wl_data_device_manager.txt Adds (new) attributes, removes section headers
wire/wl_data_device.txt Adds (new) and (destructor) attributes, removes empty lines, reorders release request
wire/wl_compositor.txt Adds (new) attributes, removes section headers
wire/wl_callback.txt Adds (destructor) attribute to done event, removes section headers
wire/wl_buffer.txt Adds (destructor) attribute, removes section headers and empty lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahkoh mahkoh merged commit 0ecf7eb into master Dec 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants