Skip to content

Conversation

@mahkoh
Copy link
Owner

@mahkoh mahkoh commented Dec 14, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the xdg-shell implementation to make the acknowledged configure serial part of the pending state. The key change is tracking serials as u64 internally while still using u32 for the wire protocol, with mapping logic to handle the conversion.

Key Changes:

  • Converted internal serial tracking from u32 to u64 with mapping functions to handle protocol u32 serials
  • Made acked serial part of the surface's pending state for proper synchronization
  • Replaced have_initial_commit boolean with an InitialCommitState enum for better state tracking
  • Changed initial_configure from returning a Result to returning nothing (removing XdgSurfaceError from the signature)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/ifs/wl_surface/xdg_surface.rs Core changes: u64 serial tracking, serial mapping logic, new InitialCommitState enum, ack_configure validation, and pending state integration
src/ifs/wl_surface/xdg_surface/xdg_toplevel.rs Updated to remove XdgSurfaceError import and changed initial_configure signature to match new trait definition
src/ifs/wl_surface/xdg_surface/xdg_popup.rs Updated to remove XdgSurfaceError import and changed initial_configure signature to match new trait definition
src/ifs/wl_surface.rs Added serial field to PendingState struct for tracking acked serials through the commit process

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahkoh mahkoh force-pushed the jorth/xdg-initial-commit-state branch from 46ef228 to 17ac4ca Compare December 14, 2025 22:22
Copy link

Copilot AI commented Dec 14, 2025

@mahkoh I've opened a new pull request, #690, to work on those changes. Once the pull request is ready, I'll request review from you.

@mahkoh mahkoh merged commit 3a4ca4d into master Dec 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants