Skip to content

Conversation

@mahkoh
Copy link
Owner

@mahkoh mahkoh commented Sep 20, 2025

@mahkoh mahkoh requested a review from Copilot September 20, 2025 20:27
@mahkoh mahkoh marked this pull request as draft September 20, 2025 20:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the ext-image-capture-color-management-v1 protocol extension to provide color management support for image capture operations. It allows clients to specify and retrieve color descriptions for captured frames.

Key changes include:

  • Adds new Wayland protocol definitions for color management in image capture
  • Implements color description tracking and listeners for surfaces and outputs
  • Integrates color descriptions into the image capture frame pipeline

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
wire/*.txt Protocol definitions for color management interfaces
src/ifs/ext_image_copy/ext_image_capture_color_manager_v1.rs Main color manager implementation
src/ifs/ext_image_capture_source_colors_v1.rs Source color tracking and event handling
src/ifs/color_management/wp_image_description_reference_v1.rs Reference object for image descriptions
src/ifs/ext_image_copy/ext_image_copy_capture_frame_v1.rs Frame color description integration
src/ifs/wl_surface.rs Surface color description listener support
src/ifs/wl_output.rs Output color description listener support
src/client/objects.rs Object storage for new types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mahkoh mahkoh force-pushed the jorth/copy-capture-color branch from 3497ecf to 1148d01 Compare September 21, 2025 14:30
@mahkoh mahkoh force-pushed the jorth/copy-capture-color branch from 1148d01 to 12da187 Compare December 18, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants