Skip to content

Remove forbidden @author tag from framework (part 2) #37019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*
* phpcs:disable Magento2.Classes.AbstractApi
* @api
* @author Magento Core Team <[email protected]>
* @SuppressWarnings(PHPMD.NumberOfChildren)
* @since 100.0.2
*/
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Button.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form button element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
10 changes: 8 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Checkbox.php
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
<?php

/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

namespace Magento\Framework\Data\Form\Element;

use Magento\Framework\Escaper;

/**
* Form checkbox element
*
* @author Magento Core Team <[email protected]>
*/
class Checkbox extends AbstractElement
{
Expand All @@ -32,6 +32,8 @@ public function __construct(
}

/**
* Get HTML attributes
*
* @return string[]
*/
public function getHtmlAttributes()
Expand All @@ -53,6 +55,8 @@ public function getHtmlAttributes()
}

/**
* Get Element HTML
*
* @return string
* @SuppressWarnings(PHPMD.UnusedLocalVariable)
*/
Expand All @@ -63,13 +67,15 @@ public function getElementHtml()
} else {
$this->unsetData('checked');
}

return parent::getElementHtml();
}

/**
* Set check status of checkbox
*
* @param bool $value
*
* @return Checkbox
*/
public function setIsChecked($value = false)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@

/**
* Form select element
*
* @author Magento Core Team <[email protected]>
*/
class Checkboxes extends AbstractElement
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

/**
* Form element collection
*
* @author Magento Core Team <[email protected]>
*/
class Collection implements \ArrayAccess, \IteratorAggregate, \Countable
{
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Column.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form column
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Date.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Magento data selector form element
*
* @author Magento Core Team <[email protected]>
*/

namespace Magento\Framework\Data\Form\Element;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
Expand All @@ -8,8 +9,6 @@
* Form editable select element
*
* Element allows inline modification of textual data within select
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down Expand Up @@ -70,7 +69,7 @@ public function __construct(
*
* This class must define init() method and receive configuration in the constructor
*/
const DEFAULT_ELEMENT_JS_CLASS = 'EditableMultiselect';
public const DEFAULT_ELEMENT_JS_CLASS = 'EditableMultiselect';

/**
* Retrieve HTML markup of the element
Expand Down Expand Up @@ -142,11 +141,12 @@ function check( tries, delay ){
*
* @param array $option
* @param string[] $selected
*
* @return string
*/
protected function _optionToHtml($option, $selected)
{
$optionId = 'optId' .$this->random->getRandomString(8);
$optionId = 'optId' . $this->random->getRandomString(8);
$html = '<option value="' . $this->_escape($option['value']) . '" id="' . $optionId . '" ';
$html .= isset($option['title']) ? 'title="' . $this->_escape($option['title']) . '"' : '';
if (in_array((string)$option['value'], $selected)) {
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Editor.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@

/**
* Form editor element
*
* @author Magento Core Team <[email protected]>
*/
class Editor extends Textarea
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
* Form fieldset
*
* @api
* @author Magento Core Team <[email protected]>
* @since 100.0.2
*/
class Fieldset extends AbstractElement
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/File.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form file element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Gallery.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Category form input image element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
12 changes: 7 additions & 5 deletions lib/internal/Magento/Framework/Data/Form/Element/Hidden.php
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
<?php

/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

/**
* Form hidden element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

use Magento\Framework\Escaper;

/**
* Form hidden element
*/
class Hidden extends AbstractElement
{
/**
Expand All @@ -33,6 +32,8 @@ public function __construct(
}

/**
* Get default HTML
*
* @return mixed
*/
public function getDefaultHtml()
Expand All @@ -41,6 +42,7 @@ public function getDefaultHtml()
if ($html === null) {
$html = $this->getElementHtml();
}

return $html;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form image file element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Link.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Magento Form element renderer to display link element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
21 changes: 17 additions & 4 deletions lib/internal/Magento/Framework/Data/Form/Element/Multiline.php
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<?php

/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

/**
* Form multiline text elements
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand All @@ -33,6 +32,8 @@ public function __construct(
}

/**
* Get HTML attributes
*
* @return string[]
*/
public function getHtmlAttributes()
Expand All @@ -53,13 +54,17 @@ public function getHtmlAttributes()
}

/**
* Get label HTML
*
* @param int $suffix
* @param string $scopeLabel
*
* @return string
*/
public function getLabelHtml($suffix = 0, $scopeLabel = '')
{
return parent::getLabelHtml($suffix, $scopeLabel);
$html = parent::getLabelHtml($suffix, $scopeLabel);
return $html;
}

/**
Expand All @@ -78,6 +83,7 @@ public function getElementHtml()
} else {
$this->setClass('input-text admin__control-text');
}

$html .= '<div class="multi-input admin__field-control"><input id="' .
$this->getHtmlId() .
$i .
Expand All @@ -97,12 +103,16 @@ public function getElementHtml()
if ($i == 0) {
$html .= $this->getAfterElementHtml();
}

$html .= '</div>';
}

return $html;
}

/**
* Get default HTML
*
* @return mixed
* @SuppressWarnings(PHPMD.NPathComplexity)
*/
Expand All @@ -129,6 +139,7 @@ public function getDefaultHtml()
$this->setClass('input-text');
$html .= '<label>&nbsp;</label>' . "\n";
}

$html .= '<input id="' .
$this->getHtmlId() .
$i .
Expand All @@ -146,13 +157,15 @@ public function getDefaultHtml()
if ($i == 0) {
$html .= $this->getAfterElementHtml();
}

$html .= $this->getNoSpan() === true ? '' : '</span>' . "\n";
}

return $html;
}

/**
* {@inheritdoc}
* @inheritDoc
*/
public function getEscapedValue($index = null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form select element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
11 changes: 6 additions & 5 deletions lib/internal/Magento/Framework/Data/Form/Element/Note.php
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
<?php

/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

/**
* Form note element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

use Magento\Framework\Escaper;

/**
* Form note element
*/
class Note extends AbstractElement
{
/**
Expand All @@ -32,6 +31,8 @@ public function __construct(
}

/**
* Get element HTML
*
* @return string
*/
public function getElementHtml()
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Obscure.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form text element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Password.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form password element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
2 changes: 0 additions & 2 deletions lib/internal/Magento/Framework/Data/Form/Element/Radio.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Form radio element
*
* @author Magento Core Team <[email protected]>
*/
namespace Magento\Framework\Data\Form\Element;

Expand Down
Loading