Added index, completion and references for table names, column names … #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bohdan-harniuk
force-pushed
the
add-index-reference-and-comletion-to-db-schema-tables-and-columns
branch
2 times, most recently
from
df995c8 to
76b7deb
Compare
bohdan-harniuk
force-pushed
the
add-index-reference-and-comletion-to-db-schema-tables-and-columns
branch
4 times, most recently
from
686b767 to
b07d4c9
Compare
VitaliyBoyko
requested changes
Oct 25, 2020
| @@ -41,6 +42,7 @@ public static void manualReindex() { | |||
| // xml|di configuration | |||
| PluginIndex.KEY, | |||
| VirtualTypeIndex.KEY, | |||
| TableAndColumnNameIndex.KEY, | |||
There was a problem hiding this comment.
Let's change it to DeclarativeSchemaElementsIndex to be more self-explanatory
bohdan-harniuk
force-pushed
the
add-index-reference-and-comletion-to-db-schema-tables-and-columns
branch
from
4eff885 to
3f41361
Compare
VitaliyBoyko
requested changes
Oct 26, 2020
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
bohdan-harniuk
force-pushed
the
add-index-reference-and-comletion-to-db-schema-tables-and-columns
branch
from
9ae74c5 to
d84e03a
Compare
|
Fixed "An element should not have a reference to itself". |
bohdan-harniuk
force-pushed
the
add-index-reference-and-comletion-to-db-schema-tables-and-columns
branch
from
d84e03a to
759617a
Compare
…in db_schema.xml file
bohdan-harniuk
force-pushed
the
add-index-reference-and-comletion-to-db-schema-tables-and-columns
branch
from
759617a to
228d36c
Compare
bohdan-harniuk
force-pushed
the
add-index-reference-and-comletion-to-db-schema-tables-and-columns
branch
from
228d36c to
0ac99de
Compare
…o-db-schema-tables-and-columns
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
…o-db-schema-tables-and-columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR adds indexes, completion, references, test coverage on completion and references on table and column names in the db_schema.xml file.
Also, was changed the assertHasReferenceToXmlTag method of the BaseReferenceTestCase class to work with PolyVariantReferenceBase type that retrieves multiple references.
After that change all tests passed successfully:
Contribution checklist (*)