Changed validator for CreateAPluginDialog #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpayyne
commented
Oct 21, 2020
Comment on lines
-240
to
-255
| final List<String> allModulesList = ModuleIndex | ||
| .getInstance(project).getEditableModuleNames(); | ||
| if (!allModulesList.contains(pluginModule)) { | ||
| final String errorMessage = validatorBundle.message( | ||
| "validator.module.noSuchModule", | ||
| pluginModule | ||
| ); | ||
| JOptionPane.showMessageDialog( | ||
| null, | ||
| errorMessage, | ||
| errorTitle, | ||
| JOptionPane.ERROR_MESSAGE | ||
| ); | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
This isn't implemented and will be done in a separate PR as per @VitaliyBoyko.
There was a problem hiding this comment.
Could you please create an Issue and reference it to this PR. TY
There was a problem hiding this comment.
Hi @VitaliyBoyko, I've created an issue for the above: #332. Thanks.
There was a problem hiding this comment.
Hi @VitaliyBoyko, I've closed the above issue and suggested a better aproach in this comment: #326 (comment).
|
Please update the PR. Thanks! |
|
Hi @VitaliyBoyko, I've fixed the merge conflicts. Also, please check #324 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the validator for CreateAPluginDialog from a dedicated class to
@FieldValidationannotationFixed Issues
Additional changes
Name->Plugin NameContribution checklist