Skip to content

Added new validation for new ViewModel dialog #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,19 @@
import com.intellij.psi.PsiFile;
import com.magento.idea.magento2plugin.actions.generation.NewViewModelAction;
import com.magento.idea.magento2plugin.actions.generation.data.ViewModelFileData;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.NewViewModelValidator;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.FieldValidation;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.annotation.RuleRegistry;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.AlphanumericRule;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.DirectoryRule;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.NotEmptyRule;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.PhpClassRule;
import com.magento.idea.magento2plugin.actions.generation.dialog.validator.rule.StartWithNumberOrCapitalLetterRule;
import com.magento.idea.magento2plugin.actions.generation.generator.ModuleViewModelClassGenerator;
import com.magento.idea.magento2plugin.magento.files.ViewModelPhp;
import com.magento.idea.magento2plugin.magento.packages.File;
import com.magento.idea.magento2plugin.magento.packages.Package;
import com.magento.idea.magento2plugin.util.magento.GetModuleNameByDirectoryUtil;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;
import java.awt.event.WindowAdapter;
import java.awt.event.WindowEvent;
Expand All @@ -28,14 +33,31 @@
import javax.swing.KeyStroke;

public class NewViewModelDialog extends AbstractDialog {
private final NewViewModelValidator validator;
private static final String VIEW_MODEL_NAME = "View Model Name";
private static final String VIEW_MODEL_DIR = "View Model Directory";
private final PsiDirectory baseDir;
private final String moduleName;

private JPanel contentPanel;
private JButton buttonOK;
private JButton buttonCancel;

@FieldValidation(rule = RuleRegistry.NOT_EMPTY,
message = {NotEmptyRule.MESSAGE, VIEW_MODEL_NAME})
@FieldValidation(rule = RuleRegistry.PHP_CLASS,
message = {PhpClassRule.MESSAGE, VIEW_MODEL_NAME})
@FieldValidation(rule = RuleRegistry.ALPHANUMERIC,
message = {AlphanumericRule.MESSAGE, VIEW_MODEL_NAME})
@FieldValidation(rule = RuleRegistry.START_WITH_NUMBER_OR_CAPITAL_LETTER,
message = {StartWithNumberOrCapitalLetterRule.MESSAGE, VIEW_MODEL_NAME})
private JTextField viewModelName;

@FieldValidation(rule = RuleRegistry.NOT_EMPTY,
message = {NotEmptyRule.MESSAGE, VIEW_MODEL_DIR})
@FieldValidation(rule = RuleRegistry.DIRECTORY,
message = {DirectoryRule.MESSAGE, VIEW_MODEL_DIR})
private JTextField viewModelParentDir;

private final Project project;

/**
Expand All @@ -50,41 +72,31 @@ public NewViewModelDialog(final Project project, final PsiDirectory directory) {
this.project = project;
this.baseDir = directory;
this.moduleName = GetModuleNameByDirectoryUtil.execute(directory, project);
this.validator = NewViewModelValidator.getInstance(this);

setContentPane(contentPanel);
setModal(true);
setTitle("Create a new Magento 2 View Model.");
getRootPane().setDefaultButton(buttonOK);
suggestViewModelDirectory();

buttonOK.addActionListener(new ActionListener() {
public void actionPerformed(final ActionEvent event) {
onOK();
}
});

buttonCancel.addActionListener(new ActionListener() {
public void actionPerformed(final ActionEvent event) {
onCancel();
}
});
buttonOK.addActionListener((final ActionEvent event) -> onOK());
buttonCancel.addActionListener((final ActionEvent event) -> onCancel());

// call onCancel() when cross is clicked
setDefaultCloseOperation(DO_NOTHING_ON_CLOSE);
addWindowListener(new WindowAdapter() {
@Override
public void windowClosing(final WindowEvent event) {
onCancel();
}
});

// call onCancel() on ESCAPE
contentPanel.registerKeyboardAction(new ActionListener() {
public void actionPerformed(final ActionEvent event) {
onCancel();
}
}, KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0),
JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT);
contentPanel.registerKeyboardAction(
(final ActionEvent event) -> onCancel(),
KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0),
JComponent.WHEN_ANCESTOR_OF_FOCUSED_COMPONENT
);
}

/**
Expand All @@ -101,7 +113,7 @@ public static void open(final Project project, final PsiDirectory directory) {
}

protected void onOK() {
if (!validator.validate()) {
if (!validateFormFields()) {
return;
}
generateFile();
Expand Down Expand Up @@ -171,6 +183,7 @@ private String getNamespace() {
return parts[0] + Package.fqnSeparator + parts[1] + Package.fqnSeparator + directoryPart;
}

@Override
public void onCancel() {
// add your code here if necessary
dispose();
Expand Down

This file was deleted.