Skip to content

Option\File: allow DateTimeImmutable in setTime() #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2021
Merged

Option\File: allow DateTimeImmutable in setTime() #198

merged 1 commit into from
Nov 2, 2021

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Nov 2, 2021

This tiny change allow me to pass DateTimeImmutable instances to File->setTime().

Thanks for maintaining this package and considering this change!

@coveralls
Copy link

coveralls commented Nov 2, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 75.629% when pulling d844998 on jorrit:datetimeimmutable into b092132 on maennchen:master.

NicolasCARPi
NicolasCARPi approved these changes Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maennchen maennchen merged commit 3b1e830 into maennchen:master Nov 2, 2021
@jorrit
Copy link
Contributor Author

jorrit commented Nov 2, 2021

Thanks!

@jorrit jorrit deleted the datetimeimmutable branch November 2, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maennchen maennchen maennchen approved these changes

@NicolasCARPi NicolasCARPi NicolasCARPi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorrit @coveralls @maennchen @NicolasCARPi