Only close self opened streams

[dennisverspuij]

Hi, thanks for the library!

I am using addFileFromStream and was suprised to see the stream resources being closed afterwards. I feel the library should only do this for streams it opens itself. Since Stream is not fopen'ing itself, it shoudn't fclose either, it is responsibility of the user.

[dennisverspuij]

Sorry, actually the File patch could instead simply read:

             $stream = new DeflateStream(fopen($path, 'rb'));
             $this->processStream($stream);
+            $stream->close();

[NicolasCARPi]

Hello,

Thank you for your contribution. You can push another commit on the same branch if needed.

[maennchen]

Thanks @dennisverspuij I fully agree, that this behavior should be changed.

@NicolasCARPi How would you proceed? This is a breaking change. Would you actually release a new major version or add some switch to opt in to the correct behavior?

[NicolasCARPi]

A new major version is the way to go if the new behavior is the "correct" one.

[dennisverspuij]

A new release would be very welcome!

[maennchen]

@NicolasCARPi Agreed

[NicolasCARPi]

So should we merge this and release a new major version then?

[maennchen]

@NicolasCARPi Yes, we should also add a Migration Help Text (also in the Readme)