Skip to content

Typos and spelling fixes to help file #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Typos and spelling fixes to help file #17

merged 1 commit into from
Apr 14, 2023

Conversation

kennypete
Copy link
Contributor

Love the plugin. I just noticed the few spelling errors/typos in the help reading it, so this is only a very minor tidy up.

It may also be worth noting in the readme or help that the vim build has to have a python3 installation of the same point version. I got briefly stumped by has("python3") returning 0 when :version returned +python3/dyn, but it turned out the Vim version was two points ahead (3.11 v 3.9) of what I had installed.

@madox2
Copy link
Owner

madox2 commented Apr 14, 2023

Thank you for the contribution, looks good!

Regarding the python issue. Yesterday I have released an update which makes external dependency openai-python no longer needed. I think that should solve the problem with different python versions you mentioned. Please install the latest version and let me know.

@madox2 madox2 merged commit a04ce2b into madox2:main Apr 14, 2023
@kennypete
Copy link
Contributor Author

kennypete commented Apr 21, 2023

Regarding the python issue. Yesterday I have released an update which makes external dependency openai-python no longer needed. I think that should solve the problem with different python versions you mentioned. Please install the latest version and let me know.

I think that fixed something else. The issue I had was that the Python version on Windows was 3.9 but the Windows gvim build had 3.11. That causes an E370 error. Problem was, I could not figure that by the error message from vim-ai alone because all it says is "Python 3 support is required for vim-ai plugin". When you check :version, Vim shows +python3/dyn, so unless you know to check what local point version of Python3 you are running (e.g., with a terminal with python --version) and compare that to the output of :python3 import sys; print(sys.version) (which will error, but let you know the python3n.dll that's missing)...

I tried with an older Vim 8.1 Windoze with the latest vim-ai and the same result (not surprisingly). My Python3 versions installed are 3.9 and 3.11, but the version in Vim 8.1 is wanting python36.dll, so vim-ai returns "Python 3 support is required for vim-ai plugin".

I hope that makes sense. Maybe the solution would be a more detailed error message like: "Python 3 support is required for the vim-ai plugin. You are either missing Python 3 or the version you have installed does not match the version that your Vim version was built with. [more]", with [more] maybe needing different O/S suggestions, which for Windows would be something like what I outlined above.

@madox2
Copy link
Owner

madox2 commented Apr 21, 2023

I know what you are talking about. Recently I tried to install vim with python support on Windows VM, and it was really painful, so I gave up. Later a friend of mine shared this link with me:
https://tuxproject.de/projects/vim

Here you can download pre-built vim binaries with some features included. I followed the instructions, installed the same python version mentioned, and then it worked well. Please let me know if the link is any help for you.

The way I see it is that enabling python support for vim is out of the scope of this plugin. However if users have issues with it, it would be worth if they could find some answers quickly. Maybe it would make sense to open an issue for that and leave some comments/documentation there.

@kennypete
Copy link
Contributor Author

https://tuxproject.de/projects/vim

Here you can download pre-built vim binaries with some features included.

https://github.com/vim/vim-win32-installer/releases is with the official repository (and python is in its builds).

The way I see it is that enabling python support for vim is out of the scope of this plugin. However if users have issues with it, it would be worth if they could find some answers quickly. Maybe it would make sense to open an issue for that and leave some comments/documentation there.

Yes, sure, I thought some improved error message, and maybe tips to solve the mismatch, would be an improvement. If I get time I'll write some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants