ci: Minor fix so that if gettext/libsodium is cached, don't warn #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when we try to set up a cached package, Homebrew generates an annoying "already installed, it's just not linked" warning which is distracting when parsing CI logs. Just make sure to run `brew install` if we don't have the package cached. Note that when a package is not cached and we have to rebuild it, Homebrew will still warn needlessly because we have HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK set. This is mostly ok because most of the time our packages should be cached in CI.
ychin
added
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we try to set up a cached package, Homebrew generates an annoying "already installed, it's just not linked" warning which is distracting when parsing CI logs. Just make sure to run
brew installif we don't have the package cached.Note that when a package is not cached and we have to rebuild it, Homebrew will still warn needlessly because we have HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK set. This is mostly ok because most of the time our packages should be cached in CI.