Skip to content

Conversation

iamGavinJ
Copy link
Contributor

bun: Update to v1.2.22

Description

  • Version bump to v1.2.22
  • Switch PortGroup from npm to github - IMO it should not be necessary to use npm to install the thing that replaces npm (and node).
Type(s)
  • security fix
  • enhancement
  • bugfix
Tested on

macOS 15.6.1 24G90 arm64
Xcode 16.4 16F6

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@JLindop for port bun.

@iamGavinJ
Copy link
Contributor Author

iamGavinJ commented Sep 14, 2025

The PR check for macOS-13 is failing because it's trying to pull in i386 but I've added supported_archs arm64 x86_64 to the Portfile so I'm not sure why it's doing that.

Is there something else I need to do to exclude i386/x86?

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamGavinJ looks like with these changes you're just downloading binaries. Beforehand it appears the package was build from source; that is what we want to do in MacPorts. So unless I'm misunderstanding this PR I doubt we want to merge this.

@iamGavinJ
Copy link
Contributor Author

@iamGavinJ looks like with these changes you're just downloading binaries. Beforehand it appears the package was build from source; that is what we want to do in MacPorts. So unless I'm misunderstanding this PR I doubt we want to merge this.

This is exactly what the npm package is doing - https://www.npmjs.com/package/bun?activeTab=code

My change achieves exactly the same thing without indirection.

Copy link
Contributor

@ryandesign ryandesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR check for macOS-13 is failing because it's trying to pull in i386 but I've added supported_archs arm64 x86_64 to the Portfile so I'm not sure why it's doing that.

Because you've based distname on os.arch. os.arch only ever has one of three possible values: powerpc (on PowerPC Macs), i386 (on Intel Macs) or arm (on Apple Silicon Macs).

@ryandesign
Copy link
Contributor

you're just downloading binaries

This is exactly what the npm package is doing - https://www.npmjs.com/package/bun?activeTab=code

How are those binaries built, and can the Portfile do that instead? MacPorts is a build from source system, not an install somebody else's binaries system.

@JLindop
Copy link
Contributor

JLindop commented Sep 17, 2025

When I first looked into building it, there was no documentation, which is why I used the NPM port group. Now it seems there is documentation, so it might be possible to change it to build from source. However, it does seem to require itself as a dependency, which may complicate things.

@ryandesign
Copy link
Contributor

it does seem to require itself as a dependency, which may complicate things.

That does complicate, but that could be a place where you could use the binaries they provide in order to build our own copy.

However, do check if there's a way to build bun without requiring bun. It seems like there must be a way, otherwise how would they ever support a new platform?

bun: Update to v1.2.22

bun: Resolving commends

bun: Fixing x86_64 Build Arch

bun: Fix Tcl Else-If typo

bun: Add separate checksums for pre-built bins

Temporary fix until true build from source is implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants