KeePassXC, -devel: update to latest #29310
Conversation
contextnerror
force-pushed
the
keepassxc
branch
from
e3cc432 to
aa71d1b
Compare
|
|
||
| patchfiles-append patch-no-deployqt.diff \ | ||
| patch-no-findpackage-path.diff \ | ||
| add_support_for_old_macos.diff \ |
There was a problem hiding this comment.
it doesn't look like you actually removed the patchfile?
There was a problem hiding this comment.
This was intentional on my part, for two reasons:
- It would be easier for others to see the file in case someone else knew how to get it working again.
- If a fix does not happen, an update can be made that pins older versions to 2.7.9 and uses the patch after seeing which versions fail to build
If neither of these are needed for now I can delete it.
There was a problem hiding this comment.
IIRC the content of the patch should be clear enough. My intent was to keep at least compatibility with 10.11 (el capitan) since many devices can't upgrade. But last time I worked on this portfile, it built starting from 10.7 to the latest.
contextnerror
force-pushed
the
keepassxc
branch
from
aa71d1b to
dfa98b5
Compare
Which older macOS versions did it fail with? There is code in the Portfile to pin the deployment target to no newer than 14.0 so that the build errors requiring the use of ScreenCaptureKit don't occur. If it now does use ScreenCaptureKit then the code pinning deployment target is no longer needed and should be removed. |
|
Here's where they added support for ScreenCaptureKit: keepassxreboot/keepassxc#11428 There seems to be at least an intent for it to work on older systems that don't have ScreenCaptureKit. |
|
@contextnerror , see my comment on https://trac.macports.org/ticket/72178#comment:4 for how to update the patch |
|
Thanks for sending me in the right direction, I have updated the patches and have gotten stable and devel to build on both my 12 and 10.14 machine. I can try and send the MAC_OS_VERSION_12_3 change upstream if desired. Will squash commits once everything is confirmed as ok. |
* patch value of MAC_OS_VERSION_12_3 to fix build on older systems * add ScreenCaptureKit to existing patches * create separate old_macos patch for devel version * make devel builds not marked as Release build type 2.7.10 adds restrictions on short custom word lists, this is not a bug. Behavior is changed in devel version. Closes: https://trac.macports.org/ticket/72178
contextnerror
force-pushed
the
keepassxc
branch
from
b53338b to
d19564f
Compare
2.7.10 adds restrictions on short custom word lists, this is not a bug. Behavior is changed in devel version.
Closes: https://trac.macports.org/ticket/72178
Description
This version is likely incompatible with older versions of macOS, I was unable to resolve the build failures related to ScreenCaptureKit. I was never sure if it was an issue with my portfile or upstream code.
Type(s)
Tested on
macOS 12.7.6 21H1320 x86_64
Command Line Tools 14.2.0.0.1.1668646533
Verification
Have you
port lint?sudo port test?sudo port -vst install?