ma_close_stream__aaudio Crash

[mbpictures]

Hi!

I just updated miniaudio to the version of the dev-12 branch and I experience a crash when unitinitializing the device in the ma_close_stream__aaudio function because pContextStateAAudio is NULL.

Here's the complete (symbolized) stacktrace:

********** Crash dump: **********
Build fingerprint: 'google/sdk_gphone64_x86_64/emu64xa:16/BE2A.250530.026.D1/13818094:user/release-keys'
#00 0x0000000000cae028 /data/app/~~XTpdMg4X8FKl8ZixEgVlfg==/com.mariusbutz.harmonyhub.debug-Y-oH4OM6Ccg2A2LddvB6Ww==/base.apk!libappmodules.so (offset 0x9830000) (BuildId: 2dbaf128df5dad7916155160b45155b9518f7fa3)
                                                                                                                                                ma_close_stream__aaudio(ma_context*, ma_AAudioStream_t**)
                                                                                                                                                miniaudio/miniaudio.h:40431:55
#01 0x0000000000cadd98 /data/app/~~XTpdMg4X8FKl8ZixEgVlfg==/com.mariusbutz.harmonyhub.debug-Y-oH4OM6Ccg2A2LddvB6Ww==/base.apk!libappmodules.so (offset 0x9830000) (BuildId: 2dbaf128df5dad7916155160b45155b9518f7fa3)
                                                                                                                                                ma_close_streams__aaudio(ma_device*)
                                                                                                                                                miniaudio/miniaudio.h:40547:9
#02 0x0000000000cb09b0 /data/app/~~XTpdMg4X8FKl8ZixEgVlfg==/com.mariusbutz.harmonyhub.debug-Y-oH4OM6Ccg2A2LddvB6Ww==/base.apk!libappmodules.so (offset 0x9830000) (BuildId: 2dbaf128df5dad7916155160b45155b9518f7fa3)
                                                                                                                                                ma_device_uninit__aaudio(ma_device*)
                                                                                                                                                miniaudio/miniaudio.h:40677:9
#03 0x0000000000cb4808 /data/app/~~XTpdMg4X8FKl8ZixEgVlfg==/com.mariusbutz.harmonyhub.debug-Y-oH4OM6Ccg2A2LddvB6Ww==/base.apk!libappmodules.so (offset 0x9830000) (BuildId: 2dbaf128df5dad7916155160b45155b9518f7fa3)
                                                                                                                                                ma_device_op_do_uninit(ma_device*, ma_device_op_completion_event*)
                                                                                                                                                miniaudio/miniaudio.h:43649:9
#04 0x0000000000c2e3eb /data/app/~~XTpdMg4X8FKl8ZixEgVlfg==/com.mariusbutz.harmonyhub.debug-Y-oH4OM6Ccg2A2LddvB6Ww==/base.apk!libappmodules.so (offset 0x9830000) (BuildId: 2dbaf128df5dad7916155160b45155b9518f7fa3)
                                                                                                                                                ma_audio_thread(void*)
                                                                                                                                                miniaudio/miniaudio.h:43966:13
#05 0x0000000000c23d55 /data/app/~~XTpdMg4X8FKl8ZixEgVlfg==/com.mariusbutz.harmonyhub.debug-Y-oH4OM6Ccg2A2LddvB6Ww==/base.apk!libappmodules.so (offset 0x9830000) (BuildId: 2dbaf128df5dad7916155160b45155b9518f7fa3)
                                                                                                                                                ma_thread_entry_proxy(void*)
                                                                                                                                                miniaudio/miniaudio.h:17813:14
#06 0x000000000007ac5f /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+63) (BuildId: fcb82240218d1473de1e3d2137c0be35)
#07 0x000000000006d94d /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+61) (BuildId: fcb82240218d1473de1e3d2137c0be35)
Crash dump is completed

This is my uninit function:

    ma_engine_stop(&engine);

    ma_resource_manager_uninit(&resourceManager);
    ma_context_uninit(&context);
    ma_device_uninit(&device);
    ma_engine_uninit(&engine);

[mbpictures]

Further investigation: I added a nullcheck for pContextStateAAudio, which prevents the crash but keeps the last "portion" of the sound playing.

[mackron]

I think this might be due to your teardown being in the wrong order. Try reordering it like this:

ma_engine_uninit(&engine);
ma_resource_manager_uninit(&resourceManager);
ma_device_uninit(&device);
ma_context_uninit(&context);

The engine depends on the resource manager, so if you kill the resource manager first, you'll pull it out from under the engine. Similarly, the engine depends on the device, so same thing there. And lastly, the device depends on the context, so the context should be last.

[mbpictures]

Thanks for the answer! I tried the reordering but experienced the same crash, so I tried commenting out the uninit calls, and the crash already happens when only calling engine_stop and engine_uninit during the teardown.

[mackron]

Can you post your ma_engine_init() code, including the config setup?

[mbpictures]

Of course!

void initialize(bool force)
{
    if (_initialized && !force) {
        return;
    }

    if (_initialized) {
        ma_resource_manager_uninit(&resourceManager);
        ma_context_uninit(&context);
        ma_device_uninit(&device);
        ma_engine_uninit(&engine);
    }

    ma_device_config deviceConfig = ma_device_config_init(ma_device_type_playback);
    deviceConfig.playback.format    = ma_format_f32;
    deviceConfig.playback.channels  = 0;
    deviceConfig.sampleRate         = 0;
    deviceConfig.dataCallback       = playbackCallback;
    deviceConfig.pUserData          = this;
    deviceConfig.notificationCallback = notificationCallback;
    setupMiniAudioResources(&deviceConfig);

    _initialized = true;
}

ma_result setupMiniAudioResources(ma_device_config* deviceConfig) {
    ma_result result;
    ma_resource_manager_config resourceManagerConfig;

    resourceManagerConfig = ma_resource_manager_config_init();
    resourceManagerConfig.decodedFormat     = ma_format_f32;   
    resourceManagerConfig.decodedChannels   = 0;    
    resourceManagerConfig.decodedSampleRate = 48000;  

    result = ma_resource_manager_init(&resourceManagerConfig, &resourceManager);
    if (result != MA_SUCCESS) {
        logMsg("initialize Failed to initialize resource manager.");
        return result;
    }

    ma_context_config config = ma_context_config_init();
    #ifdef __APPLE__
    config.coreaudio.sessionCategory = ma_ios_session_category_play_and_record;
    config.coreaudio.sessionCategoryOptions = ma_ios_session_category_option_default_to_speaker | ma_ios_session_category_option_allow_bluetooth_a2dp | ma_ios_session_category_option_allow_air_play;
    #endif
    result = ma_context_init(NULL, 0, &config, &context);

    if (result != MA_SUCCESS) {
        logMsg("initialize Failed to initialize context.");
        return result;
    }

    result = ma_device_init(&context, deviceConfig, &device);
    if (result != MA_SUCCESS) {
        logMsg("initialize Failed to initialize device.");
        return result;
    }

    ma_engine_config engineConfig = ma_engine_config_init();
    engineConfig.pDevice          = &device;
    engineConfig.pResourceManager = &resourceManager;
    engineConfig.noAutoStart      = MA_TRUE;

    result = ma_engine_init(&engineConfig, &engine);
    if (result != MA_SUCCESS) {
        logMsg("initialize Failed to initialize engine.");
        ma_device_uninit(&device);
        return result;
    }

    result = ma_engine_start(&engine);
    if (result != MA_SUCCESS) {
        printf("initialize WARNING: Failed to start engine");
    }

    _channels = ma_engine_get_channels(&engine);
    _sampleRate = ma_engine_get_sample_rate(&engine);
    return MA_SUCCESS;
}

[mackron]

I noticed you have this segment:

    if (_initialized) {
        ma_resource_manager_uninit(&resourceManager);
        ma_context_uninit(&context);
        ma_device_uninit(&device);
        ma_engine_uninit(&engine);
    }

Which is still in the incorrect order. Is that code getting hit when this crash happens? Regardless, the teardown order of that segment needs to be addressed.

Other than that, everything looks fine on the surface. Are you getting this crash 100% consistently, or is it seemingly random?

[mbpictures]

That code is not getting hit when the crash happens, but I swapped the order, thanks!

The crash is 100% consistent.

[mbpictures]

I updated miniaudio again to the current version of the dev-12 branch, but I still have the same crash.