Conversation
Previously we collected all inputs in one vector before checking the links, which is not ideal. Especially when reading many inputs (e.g. by using a glob pattern), this could cause issues like running out of file handles. By moving to streams we avoid that scenario. This is also the first step towards improving performance for many inputs.
Because we can't know the amount of links without blocking
To stay as close to the pre-stream behaviour, we want to stop processing as soon as an Err value appears in the stream. This is easiest when the stream is consumed in the main thread. Previously, the stream was consumed in a tokio task and the main thread waited for responses. Now, a tokio task waits for responses (and displays them/registers response stats) and the main thread sends links to the ClientPool. To ensure that the main thread waits for all responses to have arrived before finishing the ProgressBar and printing the stats, it waits for the show_results_task to finish.
Replaced with `futures::StreamExt::for_each_concurrent`.
Tendril is not Send by default
This reverts commit 52e52bf.
This reverts commit 89d7566.
Member
Author
|
The flamegraph shows a much more flat call stack. (It's interactive, but you have to download it and open it in a browser.) |
This was referenced Dec 17, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids creating a DOM tree for link extraction and instead uses a
TokenSinkfor on-the-fly extraction.In my hyperfine benchmarks it was about 10-25% faster than the
master.Old:
4.557 s ± 0.404 sNew:
3.832 s ± 0.131 sThe performance fluctuates a little less as well.
I also added a few more element/attribute pairs which contain links according to the HTML spec. These occur very rarely, but it's good to parse them for completeness' sake.
Furthermore tried to clean up a lot of papercuts around our types. We now differentiate between a
RawUri(stringy-types) and aUri, which is a properly parsed URI type.The extractor now only deals with extracting
RawUris while the collector creates the request objects.If someone wants to look into the code, I'd be happy for a review.
(I'll squash the commits before I merge of course. ^^)