Remove srcset attribute from list of "link" attrs

[untitaker]

Fix #390

[mre]

Oh yeah that's it! Can we add a test as well?

[untitaker]

@mre what kind of test are you looking for and where would I put one? I think a unittest is not very useful.

[mre]

I've added a test to the branch we can work with. It's a very simple thing in the extractor. It's failing right now as it will not detect the links from the srcSet. Is that how we expected it to work? Probably we should change it so that it also finds the remaining links right?

[mre]

Just pushed to your branch, hope that's fine. 😅

[mre]

I think supporting the links from srcSet will be tricky. It is detected as one string and passed to linkify. :/

[mre]

I've disabled them for now. From my side this is good to go. It's not perfect but it's definitely an improvement. @untitaker what do you say?

[untitaker]

i'm writing srcset support right now, give me a second

…

On Tue, Nov 16, 2021, at 22:07, Matthias wrote: I've disabled them for now. From my side this is good to go. It's not perfect but it's definitely an improvement. @untitaker <https://github.com/untitaker> what do you say? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMPRPXY4KHWUUGLKYZIWDUMLB27ANCNFSM5ICNEV4A>.

[untitaker]

That should be it!

…

On Mon, Nov 15, 2021, at 21:13, Matthias wrote: Oh yeah that's it! Can we add a test as well? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGMPRKQFF356BJTECIQ5L3UMFSXPANCNFSM5ICNEV4A>.

[mre]

Nicely done. Thanks! 🚀