fix: inverted gitignore behaviour for --dump-inputs #1882
fix: inverted gitignore behaviour for --dump-inputs #1882thomas-zahner merged 2 commits intolycheeverse:masterfrom
Conversation
the use of `no_ignore` was missing a `!` before being passed as skip_ignored. i figure there was some confusion about the meaning of "no ignore", it can be either: - skip ignored files, or - skip the ignore process itself. the actual meaning is the second one. the no_ignore value was used inconsistently between the main logic and the dump-inputs logic. related to https://www.github.com/lycheeverse/lychee/issues/1767
|
Thanks for catching that. Doesn't this fully resolve #1767? Did you still observe any notable differences? In the issue I only mentioned the ignore inconsistency. 😅 I should probably double check to see if I spot any other problems. |
|
Maybe! It seemed like you and mre had already covered most of the issues, so I didn't look very hard for other differences. But nothing else stood out to me. |
|
Coincidentally, while resolving clippy suggestions (too many function parameters) in #1891 I extracted the three boolean flags into a Could you take a look at 96eae64? If you agree with the changes I would like to close this PR in favour of #1891. Reviews of my PR are welcome. |
2 participants
the use of
no_ignorewas missing a!before being passed as skip_ignored. i figure there was some confusion about the meaning of "no ignore", it can be either:the actual meaning is the second one. the no_ignore value was used inconsistently between the main logic and the dump-inputs logic.
related to #1767