Always check files explicitly if specified by user or matched by user glob#1816
Merged
Always check files explicitly if specified by user or matched by user glob#1816
Conversation
Add tests for glob pattern handling and extension checks Closes: lycheeverse/lychee-action#305
Member
Author
|
This should be ready for review now. It's just two lines of actual logic changes followed by a bunch of tests to make sure I didn't break more. Once this is merged, I plan to do a hotfix release, 0.20.1 to resolve the downstream problems with lychee-action. This now also covers individual files, which will always be checked if provided. The extension does not matter in that case. |
mre
changed the title
Member
Author
|
I will go ahead and merge this since this is a problem for some lychee right now. |
Member
|
@mre Thanks for the fix, looks all good to me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that files specified via glob patterns are always checked, regardless of their extensions. This change addresses the issue where no links were found due to configuration errors. Additional tests have been added to verify glob pattern handling and extension checks.
Fixes lycheeverse/lychee-action#305